| 7 Sep 2025 |
aloisw | Wait it was fully intentional to test the buggy integer saturation? | 14:10:14 |
emily | yes and there was a blocking review from lib maintainer saying "uh. no?" | 14:11:36 |
emily | and then it got cherry-picked into a GSoC PR without modification | 14:11:51 |
emily | https://github.com/NixOS/nixpkgs/pull/433710#issuecomment-3189728351 | 14:12:47 |
emily | feeding hashString into fromHexString was not only a test, it was one of two examples in the docs!! | 14:13:28 |
emily | 🫠| 14:13:42 |
emily | it never worked on 2.3 either | 14:19:21 |
emily | so nobody ever tried to eval lib tests with 2.3 on 24.11 or 25.05, at least as the host Nix | 14:19:49 |
aloisw | In reply to @aloisw:julia0815.de Let's see whether https://gerrit.lix.systems/c/lix/+/4142 succeeds in CI, I will post backports to all supported releases if it does. It succeeds now and should unblock CI on main again. | 19:40:22 |
emily | this will update over the nixfmt bump I think? | 21:09:25 |
emily | so the Nix files should probably get reformatted | 21:09:37 |
emily | oh | 21:10:02 |
emily | you did whoops | 21:10:04 |