| 24 Nov 2025 |
piegames | Very small nit: Can we change the text "Not run" in the Gerrit Checks tab to "Queued"? Because I consistently read "Not run" as "Skipped" and get really confused | 12:56:10 |
piegames | Or maybe "Not run yet" | 12:56:16 |
Rutile (Commentator2.0) feel free to ping | and if possible show them at the top too as queued instead of not showing them, because at first glance the only thing one sees is a bunch of green checkmarks, with no indication of queued tests, and one is confused why there's no +1 Verified (yet) | 13:08:25 |
helle (just a stray cat girl) | yeah, so that is a plugin I have half done, someone needs to sit me down and make me actually finish a thing at the moment | 13:08:57 |
helle (just a stray cat girl) | I can dig up the earlier conversation at some point and should make it an issue or idk move it to zulip, anyway | 13:09:31 |
Rutile (Commentator2.0) feel free to ping | zulip and/or issue sounds sensible | 13:10:22 |
piegames | Hm, do we want a Zulip channel for Gerrit? | 15:04:18 |
raitobezarius | Infra maybe | 15:19:44 |
piegames | Uhm raitobezarius | 22:47:25 |
piegames | I appreciate you submitting these changes but they were not fully ready yet | 22:47:37 |
raitobezarius | Yes? | 22:47:40 |
piegames | lacking release notes for example | 22:47:44 |
piegames | and more tests | 22:47:50 |
piegames | (my bad for not marking them as draft) | 22:48:02 |
raitobezarius | Apologies for that, I was in a "submit routine" because too many changes are sent | 22:48:12 |
piegames | oh and also they were awaiting a flaker run :D | 22:48:24 |
raitobezarius | Next time, I won't touch your changes unless you give me an explicit request | 22:49:13 |
piegames | if not for the Flaker run I'd go with a fixup commit, but given that I currently don't even know if Nixpkgs still evaluates with them (probably?) I think a revert might be preferable | 22:49:36 |
raitobezarius | Do you think it's that time sensitive? | 22:50:02 |
piegames | I have no clue | 22:50:10 |
Rutile (Commentator2.0) feel free to ping | What happens when one pushes to a already merged cl? /cur | 22:50:13 |