| 15 Sep 2025 |
 raitobezarius | so I guess the question is | 18:33:11 |
| raitobezarius | should submodules be an available option with the path fetcher type | 18:33:18 |
| raitobezarius | or wait | 18:33:43 |
| raitobezarius | you got an error because the thing referred to self.submodules ? | 18:33:48 |
| raitobezarius | let me try to reproduce your thing | 18:34:33 |
| raitobezarius | with path | 18:34:34 |
 laurents | this is the input I had url = "path:/home/laurent/Sites/dada/alaveteli_dev"; | 18:34:35 |
| laurents | and that repo is a local clone of the github repo | 18:34:50 |
| raitobezarius | aaaaaaaah | 18:36:28 |
| raitobezarius | i see | 18:36:29 |
| raitobezarius | yeah it's a bug in the flake-self-attrs experimental implementation | 18:36:53 |
| raitobezarius | i don't think it should try to pass submodules to the path fetcher | 18:37:03 |
| raitobezarius | it should only pass it to a git fetcher | 18:37:07 |
| laurents | I'm wondering if git+file:// could work | 18:37:34 |
| raitobezarius | static std::set<std::string> allowedAttrs{"submodules"};
auto newRef(ref);
for (auto & attr : *flake.selfAttrs) {
if (!allowedAttrs.contains(attr.first)) {
throw Error("flake 'self' attribute '%s' is not supported", attr.first);
}
newRef.input.attrs.insert_or_assign(attr.first, attr.second);
}
if (newRef != ref) {
return newRef;
}
| 18:38:16 |
| raitobezarius | this is the piece of code that is wrong | 18:38:19 |
| raitobezarius | nwRef.input.attrs.insert_or_assign should NOT happen if the input DOES NOT support submodules | 18:38:36 |
| raitobezarius | and… probably a warning should be emitted to tell you "hey, you are using a fetcher that doesn't support automatically retrieving submodules, this is fine but if you forget to do it, things could not work" | 18:39:06 |
| raitobezarius | newRef.input.scheme should be the variable you should use to gate this assign | 18:39:38 |
| raitobezarius | newRef.input.scheme == "git" probably | 18:39:43 |
| raitobezarius | that being said, not using flakes here would probably be very hard if you want to keep the input.follows behavior | 18:40:28 |
| raitobezarius | basically, we need flakes-compat to support the follows system | 18:40:49 |
| raitobezarius | and then you wouldn't have to deal with this | 18:40:55 |
| raitobezarius | but you'd lose all the flakes CLI | 18:41:03 |
| raitobezarius | let's just fix that bug I'd say | 18:41:08 |
| laurents | so git+file:// instead of path:// fixes it :) | 18:41:26 |
| raitobezarius | great :) | 19:02:39 |
| raitobezarius | I still think some warning to recommend git+file:// is relevant | 19:03:21 |
| laurents | I'll see if I can work out all the layers of stuff I have to learn to fix that piece of code | 19:03:37 |
| laurents | but yes, I agree that a nice warning would be better | 19:04:00 |
