7 Sep 2025 |
emily | because lib tests were very silly | 14:08:15 |
emily | the Nixpkgs PR adding that absurd test should never have been merged either :( | 14:09:04 |
aloisw | Wait it was fully intentional to test the buggy integer saturation? | 14:10:14 |
emily | yes and there was a blocking review from lib maintainer saying "uh. no?" | 14:11:36 |
emily | and then it got cherry-picked into a GSoC PR without modification | 14:11:51 |
emily | https://github.com/NixOS/nixpkgs/pull/433710#issuecomment-3189728351 | 14:12:47 |
emily | feeding hashString into fromHexString was not only a test, it was one of two examples in the docs!! | 14:13:28 |
emily | š« | 14:13:42 |
emily | it never worked on 2.3 either | 14:19:21 |
emily | so nobody ever tried to eval lib tests with 2.3 on 24.11 or 25.05, at least as the host Nix | 14:19:49 |
aloisw | In reply to @aloisw:julia0815.de Let's see whether https://gerrit.lix.systems/c/lix/+/4142 succeeds in CI, I will post backports to all supported releases if it does. It succeeds now and should unblock CI on main again. | 19:40:22 |
emily | this will update over the nixfmt bump I think? | 21:09:25 |
emily | so the Nix files should probably get reformatted | 21:09:37 |
emily | oh | 21:10:02 |
emily | you did whoops | 21:10:04 |
emily | I remembered the diff being bigger when I inadvertently did it | 21:10:23 |
8 Sep 2025 |
| Federico DamiƔn Schonborn (he/they) changed their display name from Mr. Bones (he/they) to Federico DamiƔn Schonborn (he/they). | 00:29:27 |
aloisw | In reply to @emilazy:matrix.org you did whoops If I didn't CI would fail due to the "pre-commit" check. (Yes I learned that the hard way.) | 05:08:48 |
raitobezarius | (I'm sorry, I'm unable to catch up with this room, so I don't know if there's anything that people are blocked on a core team member or just an active committer, please mention me if so.) | 14:39:25 |
aloisw | For main the change needs to be stamped by someone with +2 access. Release branches will need code owner override in addition (I will need to fix the CI failures first though, 2.93 and 2.92 are probably flakes but 2.91 needs more effort). | 15:28:31 |
aloisw | Ok 2.93 was a flake, it is verified now. | 15:29:11 |
aloisw | The CI unblock stacks are now finished (modulo nix-copy flakes) and review requested from people I believe to have sufficient permission on all branches. | 19:08:22 |
emily | does anyone have any idea why functional-shell is so flaky | 19:21:17 |
emily | I'm consistently failing to build it on my branch on Linux to the point where I'm starting to question whether I somehow broke it | 19:21:31 |
9 Sep 2025 |
raitobezarius | I know why functional-repl is like this | 12:37:39 |
raitobezarius | But I cannot remember why functional-shell | 12:37:44 |
raitobezarius | In general, I feel like the source of flakiness is sleep as a sync-mutex primitive? | 12:37:58 |
emily | it was indeed broken by a change I made. specifically when the change is present in both host and guest Nix | 14:58:55 |
| aciceri changed their display name from zrsk to aciceri. | 15:01:01 |
raitobezarius | lovely | 16:13:44 |