| 17 May 2024 |
 jade_ | In reply to @strawberry:puppygock.gay
i tried once fixing someone's PR from github UI (literally something so small), and i never ever want to do it again for what its worth, it's probably less fucked if you use . to open codespaces, but i have never actually tried that | 01:08:44 |
 strawberry🍓 (it/pup/she/they) 🏳️⚧️ 💜 🦴 (puppygock.gay) | In reply to @jade_:matrix.org
for what its worth, it's probably less fucked if you use . to open codespaces, but i have never actually tried that i didnt actually know you can edit PRs through web vscode | 01:09:15 |
 julia | I uh might but high but where is the submit button on gerrit | 01:09:24 |
 Qyriad | Screenshot? | 01:09:30 |
| jade_ | In reply to @julia:the-apothecary.club
meanwhile rust ppl, complaining about how github's pr review workflow thingy sucks lol rust ppl even have a nice gh review process as far as gh review processes go, they have bors so they can merge-queue things, have good reviewer assignment, bors d+ to delegate merging to the author after they fix something minor, and more | 01:09:40 |
| julia | 
Download image.png | 01:09:50 |
| jade_ | In reply to @julia:the-apothecary.club
sent an image. top right | 01:09:56 |
| Qyriad | Right side of the screen | 01:09:57 |
| julia | ... i refreshed the page and it appeared | 01:10:14 |
| julia | thanks | 01:10:16 |
| Qyriad | In reply to@jade_:matrix.org
rust ppl even have a nice gh review process as far as gh review processes go, they have bors so they can merge-queue things, have good reviewer assignment, bors d+ to delegate merging to the author after they fix something minor, and more (And look how much work they had to reinvent to make Github review even bearable) | 01:10:16 |
| jade_ | that's correct | 01:10:21 |
| Qyriad | Oh yeah Gerrit needs to be refreshed to update basically anything correctly. It sucks | 01:10:30 |
| jade_ | i think it's to workaround the big gerrit instances being slow | 01:10:44 |
| jade_ | ours is fast as fuck though because it is not big | 01:10:50 |
| julia | I have pressed the merge button 🎉 | 01:11:02 |
| Qyriad | Congratulations~ | 01:11:24 |
| Qyriad | btw feel free to add anything you think might be handy to https://wiki.lix.systems/books/lix-contributors/page/gerrit | 01:13:11 |
| Qyriad | you should have edit perms | 01:13:14 |
| jade_ | 
Download image.png | 01:13:56 |
| jade_ | scuffed patch!! | 01:13:57 |
| jade_ | go brr!!! | 01:14:00 |
| Qyriad | oh niiiice | 01:14:22 |
| julia | ? | 01:14:23 |
| Qyriad | "Code Review (Gerrit)" link | 01:14:33 |
| julia | oh the tab | 01:14:34 |
| julia | I thought was referring to the 1088 change fsr | 01:15:00 |
 raitobezarius | In reply to @jade_:matrix.org
sent an image. beautiful | 01:16:32 |
| jade_ | 
Download image.png | 01:28:35 |
| jade_ | shipped on actual lix now | 01:28:35 |
