| 16 May 2024 |
 samrose | https://git.lix.systems/lix-project/lix/src/branch/main/tests/functional | 17:38:51 |
 Qyriad | yep | 17:38:57 |
| Qyriad | something that probably could be migrated separately is the stuff that sets up the daemon the test suite uses | 17:39:16 |
|  aprl joined the room. | 18:30:38 |
 puck | domen?? https://github.com/NixOS/nixpkgs/blob/741342772c768588878be460f0e1aa9e6d8d0caa/pkgs/by-name/de/devenv/package.nix#L19-L30 | 18:45:40 |
| Qyriad | o.o | 18:46:06 |
| puck | pushed a fix lmao | 18:51:40 |
| Qyriad | Wait to what | 18:52:17 |
| puck | nixos-module; devenv wouldn't build with the overlay attached because it overrided the source of pkgs.nix | 18:52:41 |
| puck | * nixos-module; devenv wouldn't build with the overlay attached because it locally overrided the source of pkgs.nix | 18:52:47 |
| puck | and the build system changes meant that it broke | 18:52:54 |
| puck | https://git.lix.systems/lix-project/nixos-module/commit/53d713eb486f21d653af3ef3528e9a19ecfc45e5 | 18:54:09 |
| Qyriad | ahh | 19:01:23 |
| Qyriad | ty | 19:01:25 |
 raitobezarius | In reply to @puck:puck.moe
domen?? https://github.com/NixOS/nixpkgs/blob/741342772c768588878be460f0e1aa9e6d8d0caa/pkgs/by-name/de/devenv/package.nix#L19-L30 oh so we found another fork of nix? | 19:10:20 |
 delroth | In reply to @raitobezarius:matrix.org
oh so we found another fork of nix? Literally, you can't make this up. | 19:14:05 |
| raitobezarius | Redacted or Malformed Event | 19:14:19 |
|  morguwuldir 🏳️⚧️ set a profile picture. | 22:46:38 |
| delroth | Qyriad: if you have some time I'd love some input on whether the fix I have in mind for https://git.lix.systems/lix-project/lix/issues/312 is what you also had in mind (if you did have a fix in mind) / something that matches your expectations | 22:49:57 |
| delroth | (also if you'd rather have no ping here for stuff like that because you process bug / CL notifications async, lmk, I have no clue how y'all work so I'm defaulting to over-notifying...) | 22:50:28 |
| Qyriad | Failing at parse time is the solution we envisioned | 22:53:59 |
| Qyriad | We had the E/easy on there since we imagined it would be as simply as changing the assertion to a user-facing error message, but seem to have underestimated the difficulty in that itself, oops | 22:54:40 |
| Qyriad | (And yeah pinging us like this is fine) | 22:55:42 |
 jade_ | Qyriad: ok if we stage the libnixexpr->liblixexpr etc change? | 22:57:23 |
| jade_ | (pinging as assignee) | 22:57:42 |
| delroth | In reply to @qyriad:katesiria.org
We had the E/easy on there since we imagined it would be as simply as changing the assertion to a user-facing error message, but seem to have underestimated the difficulty in that itself, oops nah I think that if you had explained your envisioned fix it would have been fairly trivial but having to independently come to the same conclusion without having the same background was harder :P | 22:57:50 |
| delroth | still, happy it was the same conclusion (roughly - I think rejecting at parsing time is better than failing when making the worker goals, but that's tiny details) | 22:58:22 |
| Qyriad | In reply to@jade_:matrix.org
Qyriad: ok if we stage the libnixexpr->liblixexpr etc change? Yes, absolutely. If you are getting to it before us feel free! | 22:58:53 |
| jade_ | alrighty | 22:58:58 |
| Qyriad | In reply to@delroth:delroth.net
nah I think that if you had explained your envisioned fix it would have been fairly trivial but having to independently come to the same conclusion without having the same background was harder :P Yes we absolutely should have done that. I think in retrospect we may also have been somewhat confused, since the crash doesn't happen on Nix 2.3 because of course Nix 2.3 didn't have the ^ feature | 22:59:37 |
