| 30 May 2024 |
| polygon system (she/it/they) [DECT 7659] changed their display name from polygon system (she/it/they) to polygon system (she/it/they) [DECT 7659]. | 09:31:36 |
| thubrecht joined the room. | 09:46:21 |
thubrecht | Hi, I'm back from breaking the CI, I redid the primops CLs, and I pushed the code in sb/tom-hubrecht/primops.cc-v2 | 09:47:27 |
ma27 | https://gerrit.lix.systems/c/lix/+/1343?tab=checks+doesn%27t+seem doesn't seem to have any checks added. Am I doing something wrong or can I trigger those somewhere? | 11:52:00 |
K900 | Sign in to buildbot | 11:52:38 |
K900 | It's fetching the data on the client for some reason | 11:52:50 |
aloisw | It also doesn't have the "verified", so it seems it actually didn't build. | 12:14:35 |
delroth | In reply to @ma27:nicht-so.sexy https://gerrit.lix.systems/c/lix/+/1343?tab=checks+doesn%27t+seem doesn't seem to have any checks added. Am I doing something wrong or can I trigger those somewhere? I think the buildbot queue had to be emptied yesterday evening and this was maybe collateral damage | 12:32:05 |
delroth | someone can maybe retrigger CI - I don't have perms to do so :) | 12:32:27 |
raitobezarius (DECT: 7248) | I'm trying to take care of it | 13:52:02 |
raitobezarius (DECT: 7248) | But Internet is really bad | 13:52:05 |
raitobezarius (DECT: 7248) | ok | 14:05:16 |
raitobezarius (DECT: 7248) | i just did a dumb thing | 14:05:18 |
raitobezarius (DECT: 7248) | i edited the commit message | 14:05:21 |
raitobezarius (DECT: 7248) | ok let's go | 14:05:49 |
raitobezarius (DECT: 7248) | restarted | 14:05:56 |
raitobezarius (DECT: 7248) | let me know if there's any build cancelled you care about | 14:06:02 |
delroth | also lost the code-review: +2 in the process though | 14:06:26 |
raitobezarius (DECT: 7248) | thanks, it came back | 14:06:59 |
raitobezarius (DECT: 7248) | i didn't find an easy way to look up a buildbot id number from the CL number | 14:07:47 |
jade_ | https://gerrit.lix.systems/c/lix/+/1356 there's another 20% off the build time | 20:58:03 |
jade_ | real deep discount on build times as of late | 20:58:37 |
jade_ | i think that if we managed to move all the json stuff into one staticlib or something then unity-built it, we could probably save about 40% of build time. like. i see about 400s on-cpu instantiating nlohmann stuff, but it may be that those are not actually additive and it's actually 200s. either way. our json parsing is expensive | 21:10:44 |
jade_ |  Download image.png | 21:13:05 |
Qyriad | In reply to@delroth:delroth.net someone can maybe retrigger CI - I don't have perms to do so :) you're supposed to | 23:13:17 |
Qyriad | lemme fix that | 23:13:28 |
Qyriad | you may have to log out and log back in, but you should have those permissions now | 23:14:30 |
Qyriad | In reply to@jade_:matrix.org i think that if we managed to move all the json stuff into one staticlib or something then unity-built it, we could probably save about 40% of build time. like. i see about 400s on-cpu instantiating nlohmann stuff, but it may be that those are not actually additive and it's actually 200s. either way. our json parsing is expensive we could also switch away from nlohmann and probably gain some runtime JSON performance too | 23:14:52 |
| 31 May 2024 |
julia | Qyriad: just acked some of the comments with cl/1160 & cl/1161 and removed some code TODOs, since you just rebased them, if build suceeds is OK to merge them...? | 13:06:50 |
julia | although I suppose you probably need to do a code review+2 again | 13:06:59 |