| 27 Aug 2023 |
 Nadim Kobeissi | It doesn't seem to have recompiled plasma-desktop while creating the ISO | 08:48:41 |
 K900 ⚡️ | Does <nixpkgs> point at your modified nixpkgs checkout? | 08:51:06 |
| Nadim Kobeissi | No, I don't think so | 08:51:23 |
| K900 ⚡️ | Then you want to use ~/Code/nixos/nixpkgs/nixos instead of <nixpkgs/nixos> | 08:51:42 |
| Nadim Kobeissi | Understood | 08:51:50 |
| Nadim Kobeissi | NIX_PATH=localdev=/home/nadim/Code/nixos/nixpkgs/nixos nix-build '<localdev>' -A config.system.build.isoImage -I nixos-config=installation-cd-graphical-plasma5.nix | 08:55:41 |
| Nadim Kobeissi | 
Download Screenshot_20230827_110456.png | 09:05:29 |
| Nadim Kobeissi | It works! | 09:05:30 |
| Nadim Kobeissi | K900 ⚡️: Updated the issue: https://github.com/NixOS/nixpkgs/pull/251726 | 09:11:46 |
| K900 ⚡️ | As I said, please squash your commits and make the commit message match the guidelines in CONTRIBUTING.md | 09:12:09 |
| K900 ⚡️ | Also please include these screenshots in the issue | 09:12:22 |
| Nadim Kobeissi | The commit message does match, no? | 09:12:30 |
| K900 ⚡️ | There's three, currently, and no, they don't | 09:14:07 |
| K900 ⚡️ | Also, I'm pretty sure you can remove your Kickoff changes | 09:14:31 |
| Nadim Kobeissi | Why, though? | 09:14:42 |
| Nadim Kobeissi | Why do we want Discover in kickoff? | 09:14:54 |
| K900 ⚡️ | We dpm | 09:16:01 |
| K900 ⚡️ | * We don't | 09:16:02 |
| K900 ⚡️ | But Kickoff should automatically ignore non-existant shortcuts | 09:16:11 |
| Nadim Kobeissi | Alright | 09:16:17 |
| K900 ⚡️ | Also, please rebase on top of master if you need changes from master | 09:17:23 |
| K900 ⚡️ | Instead of merging it | 09:17:25 |
| K900 ⚡️ | Otherwise the history will be very messy | 09:17:32 |
| Nadim Kobeissi | No problem | 09:18:29 |
| Nadim Kobeissi | Alright, here we go: https://github.com/NixOS/nixpkgs/pull/251746 | 09:32:46 |
| K900 ⚡️ | Would prefer the commit message to be something more descriptive | 09:37:29 |
| K900 ⚡️ | Like "plasma-desktop: remove Discover shortcut from default panel" | 09:37:42 |
| Nadim Kobeissi | I think we're good, man. :P | 09:37:43 |
| K900 ⚡️ | We're really not | 09:38:56 |
| K900 ⚡️ | This is a huge repo with thousands of contributors | 09:39:02 |
