| 27 Aug 2023 |
 Ulrik Strid | You should probably write a actual `.patch` and apply it | 07:17:08 |
 Nadim Kobeissi | Ulrik Strid: OK, I'll look at existing .patches for other NixOS packages and see if I can build something similar | 07:17:45 |
| Nadim Kobeissi | Thanks for your patience, still learning... | 07:18:02 |
 K900 ⚡️ | You really don't need to be looking at the patches themselves | 07:18:37 |
| K900 ⚡️ | You just need to get the source code of whatever package the default config is defined in | 07:18:49 |
| K900 ⚡️ | Which is probably plasma-desktop | 07:18:52 |
| K900 ⚡️ | Then make the changes to remove the icon | 07:18:57 |
| K900 ⚡️ | And then use something like git diff to get the diff that's already properly formatted | 07:19:10 |
| Nadim Kobeissi | Oh, I know, but I wanted to look at other patches to see how NixOS applies patches upon package installation | 07:20:03 |
| Nadim Kobeissi | To see where/how I would need to store my own new patch | 07:20:12 |
| K900 ⚡️ | You'd want to copy it to the package directory and add it to this list: https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/plasma-5/plasma-desktop/default.nix#L126 | 07:21:52 |
| Ulrik Strid | You'll just put the patch next to the package (probably) and add the path to the `patches` list 😊 | 07:21:52 |
| Nadim Kobeissi | Ah totally understood | 07:22:06 |
| Nadim Kobeissi | Thank you! | 07:22:07 |
| Nadim Kobeissi | https://github.com/NixOS/nixpkgs/pull/251726 | 07:48:49 |
| Nadim Kobeissi | I think I did it right? | 07:49:17 |
| K900 ⚡️ | I think so, but also, can you check the unstable images? | 07:53:37 |
| K900 ⚡️ | I think they might have fixed it so invalid shortcuts are auto-removed | 07:53:46 |
| Nadim Kobeissi | Where do I check unstable? | 07:54:22 |
| K900 ⚡️ | https://channels.nixos.org/nixos-unstable/latest-nixos-plasma5-x86_64-linux.iso | 07:54:36 |
| Nadim Kobeissi | OK, I'll boot it in a VM | 07:54:58 |
| Nadim Kobeissi | 
Download Screenshot_20230827_101542.png | 08:15:52 |
| Nadim Kobeissi | K900 ⚡️: Can confirm that unstable channel still includes the icon. | 08:15:53 |
| K900 ⚡️ | OK | 08:16:18 |
| K900 ⚡️ | Please adjust the commit messages to match the convention | 08:16:30 |
| K900 ⚡️ | (and really squash them into one commit) | 08:16:35 |
| K900 ⚡️ | Actually wait | 08:17:12 |
| K900 ⚡️ | No | 08:17:12 |
| K900 ⚡️ | That entire change is wrong | 08:17:15 |
| K900 ⚡️ | You're editing Kickoff defaults, not panel defaults | 08:17:23 |
