| 12 Dec 2022 |
 Ulrik Strid | CMake Error at /nix/store/vh76h64xifdiylk1dfc9s6mgpzazngxs-cmake-3.24.3/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find KF5 (missing: MailCommon PimCommonAkonadi) (found suitable
version "5.22.0", minimum required is "5.21.0")
Call Stack (most recent call first):
/nix/store/vh76h64xifdiylk1dfc9s6mgpzazngxs-cmake-3.24.3/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
/nix/store/4zarzl3kzniwfmmy82jybyjwdl55pp1y-extra-cmake-modules-5.100.0/share/ECM/find-modules/FindKF5.cmake:93 (find_package_handle_standard_args)
CMakeLists.txt:85 (find_package)
| 19:51:30 |
| Ulrik Strid | Any ideas? | 19:51:57 |
 K900 | Sounds like it might just need some extra stuff in inputs | 19:52:03 |
| K900 | That wasn't there before | 19:52:08 |
| Ulrik Strid | gpgme was needed now so I added that | 19:52:34 |
| Ulrik Strid | But the weird thing is that it said it found the version right? | 19:53:35 |
| K900 | It's a single FindPackage for all of KF5 | 19:55:13 |
| K900 | That takes the required subpackages as arguments | 19:55:19 |
| Ulrik Strid | Ah, then I understand what I need to do | 19:57:28 |
| Ulrik Strid | Got to the buildPhase now so things are looking OK | 20:06:26 |
| Ulrik Strid | not sure if there's a reason for the order of deps so I just added them as I needed them | 20:10:49 |
| Ulrik Strid | Pushed to the PR | 20:10:54 |
| Ulrik Strid | Fixed, Sandro 🐧 and K900 if you have time for another round of review that would be awesome | 20:20:52 |
| 13 Dec 2022 |
| Ulrik Strid | In reply to @k900:0upti.me
https://kde.org/announcements/frameworks/5/5.101.0/ https://github.com/NixOS/nixpkgs/pull/205921 | 14:59:03 |
 Sandro 🐧 | In reply to @ulrikstrid:matrix.org
Fixed, Sandro 🐧 and K900 if you have time for another round of review that would be awesome I rebuild my system with it in the next day and unless no one else merged it I'll do it | 16:42:01 |
| K900 | I'm still in the hospital so I can't really test it | 16:42:24 |
| K900 | But diff seems fine | 16:42:27 |
| Ulrik Strid | In reply to @sandro:supersandro.de
I rebuild my system with it in the next day and unless no one else merged it I'll do it Do you want me to squash things? If so, how? 2 commits? | 16:43:35 |
| Ulrik Strid | In reply to @k900:0upti.me
I'm still in the hospital so I can't really test it Couldn't start a nixpkgs-review before but could now so letting it run | 16:50:44 |
| Sandro 🐧 | keep it like it is | 16:52:12 |
| 14 Dec 2022 |
| Ulrik Strid | K900: material-kwin-decoration is broken by new kde-frameworks because it uses a deprecated method. Do I mark the package as broken or do I allow use of deprecated methods? | 10:23:55 |
| K900 | Are they building with -Werror | 10:24:13 |
| K900 | Just patch out the -Werror if it's that, -Werror is cursed anyway | 10:24:27 |
| Ulrik Strid | /build/source/src/AppMenuModel.cc:124:137: error: 'void KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2)' is deprecated: Since 5.101. Use KX11Extras::windowChanged [-Werror=deprecated-declarations]
124 | void (KWindowSystem::*myWindowChangeSignal)(WId window, NET::Properties properties, NET::Properties2 properties2) = &KWindowSystem::windowChanged;
| ^~~~~~~~~~~~~
| 10:24:34 |
| Ulrik Strid | Seems to build when I remove that, so I think the PR should be ready | 10:29:07 |
| Ulrik Strid | Anyone up for a review? https://github.com/NixOS/nixpkgs/pull/205921
nixpkgs-review passes | 12:36:49 |
| Ulrik Strid | * Anyone up for a review? https://github.com/NixOS/nixpkgs/pull/205921
nixpkgs-review passes (no new errors) | 12:37:14 |
| K900 | I'll run-test in a bit and merge | 15:33:56 |
| Sandro 🐧 | builds on my plasma and so far nothing has broken | 15:39:29 |
| K900 | It shouldn't really break anything, KF5 is very stable at this point | 15:42:25 |
