| 7 Aug 2025 |
K900 | * It's not actually a bug in Calamares | 13:51:13 |
K900 | It's just our plugin being shit | 13:51:18 |
emily | yes | 14:02:57 |
emily | but have you seen how many people complain about it and get confused | 14:03:05 |
emily | the people who are precisely the target market for a nice smooth graphical installer | 14:03:11 |
K900 | Yes but it can be fixed | 14:05:17 |
emily | nobody is gonna fix it but ok :P | 15:47:42 |
emily | I left a review | 15:47:53 |
K900 | The commit rewrite is intentinoal | 15:48:41 |
emily | FWIW you may have to ping vlinkz on fediverse or similar | 15:48:41 |
K900 | * The commit rewrite is intentonal | 15:48:43 |
K900 | * The commit rewrite is intentional | 15:48:46 |
emily | my experience is that he is around but bad at noticing pings | 15:49:00 |
K900 | Doing it with git subtree doesn't rewrite the paths on the history | 15:49:01 |
emily | er, yeah that's the point. the merge rewrites the paths | 15:49:14 |
emily | you keep the trail of commit hashes | 15:49:28 |
K900 | But then if you say git log pkgs/by-name/ca/calamares-nixos-extensions/src/whatever it gives you nothing | 15:51:29 |
K900 | But just the merge | 15:51:31 |
K900 | Because before the merge it exists at /whatever | 15:52:05 |
emily | git log --follow | 15:52:15 |
K900 | Doesn't work | 15:52:21 |
K900 | It isn't considered a rename | 15:52:26 |
K900 | git is extremely stupid about this | 15:52:38 |
emily | huh? it definitely should be considered a rename considering rename detection is entirely heuristics | 15:53:03 |
K900 | I wish I could tell you | 15:53:19 |
emily | let me try it | 15:53:32 |
K900 | Oh, it also fails to rebase randomly if someone touches flake.nix or .editorconfig or whatever at nixpkgs root | 15:53:42 |
K900 | Because as far as the old history is concerned THAT'S THE THING | 15:53:57 |
emily | well it's just a one-time merge and we shouldn't be using the normal Git merge algo for it anyway (that's what subtree merges are for in the first place) | 15:54:20 |
emily | but let me see if I can reproduce | 15:54:22 |