25 Aug 2025 |
Grimmauld (any/all) | alternatively we just set ENABLE_BROWSER on the fcitx5 chinese thingy to unbreak until we actually migrate the thing to qt6 | 21:10:47 |
Grimmauld (any/all) | i propose https://github.com/NixOS/nixpkgs/pull/436892 as an unblocker for now | 21:17:35 |
emily | fcitx5 test is not a blocker I think | 22:08:38 |
emily | but I would prefer to have a solution | 22:08:46 |
emily | Grimmauld (any/all): ok so this is the only thing the browser stuff enables https://github.com/fcitx/fcitx5-chinese-addons/blob/4d10a4a84f87c0a96969583115c91928f54802d1/gui/pinyindictmanager/pinyindictmanager.cpp#L274 | 22:25:34 |
emily | seems pretty droppable | 22:26:12 |
emily | wonder if it even still works | 22:26:23 |
emily | uh | 22:26:57 |
emily | https://github.com/fcitx/fcitx5-chinese-addons/commit/a52466e99457e0aec98800370d406d8d37d2bd66 | 22:26:58 |
emily | I think we can just switch to the Qt 6 version⦠| 22:27:07 |
emily | also | 22:27:30 |
emily | yeah it looks like it was not even using WebEngine on 5. | 22:27:36 |
Grimmauld (any/all) | Lol | 22:31:01 |
Grimmauld (any/all) | Fair enough | 22:31:05 |
Grimmauld (any/all) | If its not blocking, I sleep. | 22:31:40 |
emily | I mean your PR is fine because it results in literally no functionality change AFAICT | 22:31:42 |
emily | but maybe we just switch | 22:31:53 |
emily | it is not blocking AFAIK | 22:32:21 |
Grimmauld (any/all) | We should switch, but I cba to read into fcitx at midnight when I have work to do tomorrow | 22:32:23 |
emily | it uses an alias so | 22:32:24 |
emily | not sure it would even eval on Hydra | 22:32:28 |
26 Aug 2025 |
Grimmauld (any/all) | https://github.com/NixOS/nixpkgs/pull/417815 emily K900 turns out fcitx5 solved itself. Migrated to qt6, and qtwebengine was removed from the chinese thing too | 20:09:04 |
emily | I don't think the WebEngine thing was removed upstream? | 20:09:35 |
emily | it wasn't from the package either | 20:10:09 |
emily | but yeah this works | 20:10:11 |
Grimmauld (any/all) | it was removed from our package by someone who knows more fcitx than i do so 𤷠| 20:10:20 |
emily | where? | 20:10:35 |
emily | I am looking at the diff and I still see qtwebengine | 20:10:45 |
Grimmauld (any/all) | ah damn i am blind | 20:11:21 |
Grimmauld (any/all) | oops | 20:11:24 |