5 Sep 2024 |
K900 | But effectively that makes it part of the key | 07:44:26 |
K900 | In the global space | 07:44:28 |
outfoxxed | the application can also change that | 07:44:32 |
K900 | Yes | 07:44:35 |
outfoxxed | we shouldnt touch it | 07:44:35 |
K900 | I'm not saying we should | 07:44:39 |
K900 | But it matters for cleanup purposes | 07:45:37 |
outfoxxed | the only relevant part is the qmlc url | 07:45:36 |
K900 | Because e.g. we will never clean up other applications' caches | 07:45:45 |
outfoxxed | i don't think we should be patching in extra cleanup | 07:45:50 |
outfoxxed | * i don't think we should be patching in extra cleanup that isn't upstream | 07:46:01 |
outfoxxed | but we should maintain the same level | 07:46:06 |
outfoxxed | trying to do extra cleanup will put us into some position where we're deleting caches of something that expected the normal behavior | 07:47:10 |
outfoxxed | and I don't see a reasonable way to do it, because theres no definite point where all qml resources will be loaded in the application's lifetime | 07:47:44 |
K900 | There's a weird problem | 07:47:50 |
K900 | If we have bare QML files in the store | 07:47:59 |
outfoxxed | and no guarantee they're all qrc:/ resources either | 07:47:59 |
K900 | We will never clean up those | 07:48:07 |
K900 | Because we'll be hashing the full store path | 07:48:20 |
K900 | So we'll never get a wrong hit' | 07:48:25 |
K900 | * So we'll never get a wrong hit | 07:48:26 |
outfoxxed | hm | 07:48:42 |
outfoxxed | yeah | 07:48:44 |
outfoxxed | that was what kirigami did wasn't it | 07:48:52 |
K900 | I don't like this whole lookup key versus integrity key thing they've got going on | 07:48:54 |
outfoxxed | In reply to @outfoxxed:outfoxxed.me sent an image. yeah | 07:49:06 |
K900 | Like we're looking into the cache for one thing | 07:49:11 |
K900 | And then cleaning it based on something else entirely | 07:49:28 |
outfoxxed | In reply to @k900:0upti.me I don't like this whole lookup key versus integrity key thing they've got going on the purpose just seems to be so they don't spam duplicate cache files much | 07:49:32 |
K900 | Yeah I get that | 07:49:38 |