| 5 Sep 2024 |
 outfoxxed | check the cmake file the patch is on, the logic is there | 08:28:25 |
| outfoxxed | in the tarballs there should just be a .tag file in the root | 08:28:34 |
 K900 | My brain just ignores cmake unless forced to | 08:28:37 |
| K900 | But yeah that works | 08:28:42 |
| outfoxxed | i don't think we should even need to set it though | 08:29:00 |
| K900 | But also I'm thinking just hashing the store path might be weird for like locally built things | 08:29:02 |
| K900 | We should because we could have a different build of the same Qt version | 08:29:24 |
| K900 | With a different struct layout | 08:29:30 |
| K900 | That's not guaranteed to be consistent across ABIs etc | 08:29:43 |
| outfoxxed | but there shouldnt be a different struct layout with the same qt version | 08:29:44 |
| outfoxxed | 
Download image.png | 08:30:01 |
| outfoxxed | tag is the full git hash | 08:30:03 |
| K900 | There can be if it's running like | 08:30:05 |
| K900 | aarch64 Qt in qemu-user | 08:30:11 |
| K900 | Or some nonsense | 08:30:12 |
| outfoxxed | uh
i guess technically? | 08:30:30 |
| K900 | Basically store path is 100% safe so I think we do store path | 08:30:31 |
| K900 | Unless there's strong reasons not to | 08:30:35 |
| K900 | Like OK we'll get the cache blown out once a staging cycle | 08:30:49 |
| outfoxxed | alright
lets drop the patch and just write .tag in preconfigure though | 08:30:51 |
| K900 | Is that really a problem | 08:30:52 |
| K900 | Agreed | 08:30:55 |
| outfoxxed | not as long as its able to clean up | 08:31:00 |
| outfoxxed | which it can since thats validation not id | 08:31:10 |
| K900 | OK so our key structure ends up being (app name, filename hash, ["build-id", mtime]) | 08:33:46 |
| K900 | Where build-id is either Qt "tag" or hash(Qt "tag" + app store path) depending on whether we're outside of the store or inisde | 08:34:16 |
| K900 | And when we're inside the store, mtime is 0 | 08:34:28 |
| K900 | So technically we end up with either (Qt "tag", mtime) or (Qt "tag", app store path) | 08:34:51 |
| K900 | And when I spell it out like that it kinda makes more sense to maybe hash the app store path into mtime instead? | 08:35:04 |
| outfoxxed | the only problem with that is you have 8 bits | 08:35:19 |
