| 2 Jan 2024 |
@cameronraysmith:matrix.org | * knkski: there are default overrides for pytorch-lightning that attempt to handle what must have previously been something like a nested tarball. I removed these from an experimental branch on my fork and things work as expected when I source it in my flake. I was going to discuss submitting these upstream, but it might be necessary to retain these unpackPhase customizations with version guards for backward compatibility.
I could add these if I knew where things changed, but I didn't manage to bisect where that is in the pytorch-lightning release history after trying as far back as 1.9.4 and sporadically downloading a few of the very early source distributions to inspect their structure.
| 22:49:09 |
@cameronraysmith:matrix.org | * knkski: there are default overrides for pytorch-lightning that attempt to handle what must have previously been something like a nested tarball. I removed these from an experimental branch on my fork and things work as expected when I source it in my flake. I was going to discuss submitting these upstream, but it might be necessary to retain these unpackPhase customizations with version guards for backward compatibility.
I could add these if I knew where things changed, but I didn't manage to bisect where that is in the pytorch-lightning release history after trying as far back as 1.9.4 and sporadically downloading a few of the very early source distributions from PyPI to inspect their structure.
| 22:49:32 |
@cameronraysmith:matrix.org | * knkski: there are default overrides for pytorch-lightning that attempt to handle what must have previously been something like a nested tarball. I removed these from an experimental branch on my fork and things work as expected when I source it in my flake. I was going to discuss submitting these upstream, but it might be necessary to retain these unpackPhase customizations with version guards for backward compatibility.
I could add these if I knew where things changed, but I didn't manage to bisect where that is in the pytorch-lightning release history after trying as far back as 1.9.4 and sporadically downloading a few of the very early source distributions from PyPI to inspect their structure.
| 22:50:10 |
knkski | I'll see if I can help bisect exactly where. I do remember that 1.5.3 installed with no issue, and 1.5.4 had some issue. I don't remember if it was the same one though | 22:50:27 |
@cameronraysmith:matrix.org | That sounds like a good start. I'll take a look around that time.
| 22:51:02 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added Oct 31 2022 it should be somewhere in the 1.7.7 to 1.9.4 range.
| 22:58:15 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added Oct 31 2022 it should be somewhere in the Sep 22 2022 1.7.7 to 1.9.4 range.
| 22:59:06 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added Oct 31 2022 it should be somewhere in the release prior to that Sep 22 2022 1.7.7 and the last one 1.9.4 I checked manually.
| 23:00:06 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in #786 Oct 31 2022 it should be somewhere in the release prior to that Sep 22 2022 1.7.7 and the last one 1.9.4 I checked manually.
| 23:00:32 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in #786 Oct 31 2022 it should be somewhere in the release prior to that Sep 22 2022 1.7.7 and the last one 1.9.4 I checked manually.
| 23:00:45 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in #786 Oct 31 2022 it should be somewhere in the release prior to that Sep 22 2022 1.7.7 and the last one, 1.9.4, I checked manually.
| 23:01:09 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in #786 Oct 31 2022 it should presumably be somewhere in the release prior to that Sep 22 2022 1.7.7 and the last one, 1.9.4, I checked manually.
| 23:01:45 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in #786 Oct 31 2022 the change should presumably be somewhere in the release prior to that Sep 22 2022 1.7.7 and the last one, 1.9.4, I checked manually.
| 23:01:58 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in #786 Oct 31 2022 the change should presumably be somewhere in the release prior to that Sep 22 2022 1.7.7 and the oldest one, March 2 2023 1.9.4, I checked manually.
| 23:02:56 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in #786 Oct 31 2022 the change should presumably be somewhere in the release prior to that Sep 22 2022 1.7.7 and the oldest one I checked manually from March 2 2023 in 1.9.4.
| 23:03:35 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in #786 Oct 31 2022 the change should presumably be somewhere between the release prior to that Sep 22 2022 1.7.7 and the oldest one I checked manually from March 2 2023 in 1.9.4.
| 23:04:30 |
@cameronraysmith:matrix.org | * That sounds like a good start. I'll take a look around that time.
Since the unpackPhase was added in poetry2nix #786 Oct 31 2022 the change should presumably be somewhere between the pytorch-lightning release prior to that Sep 22 2022 1.7.7 and the oldest one I checked manually from March 2 2023 in 1.9.4.
| 23:05:05 |