| 9 Nov 2023 |
 matthewcroughan | safetensors = super.safetensors.overridePythonAttrs
(
old: {
sourceRoot = "safetensors-0.4.0/bindings/python";
cargoDeps = pkgs.rustPlatform.importCargoLock {
lockFile = ./nix/safetensors/Cargo.lock;
};
nativeBuildInputs = (old.nativeBuildInputs or [ ]) ++ [
pkgs.rustPlatform.cargoSetupHook
pkgs.rustPlatform.maturinBuildHook
];
}
);
| 19:21:54 |
 K900 | It doesn't have "no metadata" | 19:21:58 |
| K900 | It's missing something | 19:22:06 |
| matthewcroughan | Oh, it can't find the package | 19:22:17 |
| matthewcroughan | * Oh, it can't find the package? | 19:22:19 |
| K900 | You can try calling importlib.metadata.version("safetensors") in a Python shell yourself | 19:22:20 |
| matthewcroughan | PackageNotFoundError | 19:22:23 |
| K900 | And see why it fails | 19:22:24 |
| matthewcroughan | ls result/lib/python3.11/site-packages/safetensors_
safetensors_python-0.4.0.dist-info/ safetensors_rust/
| 19:24:05 |
| matthewcroughan | grrr | 19:24:21 |
| matthewcroughan | it's not ending up in the site-packages | 19:24:26 |
| matthewcroughan | but the dist-info is | 19:24:44 |
| K900 | The dist-info is for safetensors_python | 19:25:56 |
| K900 | But the package it's looking for is safetensors | 19:26:04 |
| K900 | Have fun | 19:26:07 |
| matthewcroughan | safetensors definitely gets built as part of building this application, I'm not sure why it doesn't end up in site-packages | 19:26:52 |
| matthewcroughan | is it because the package is misnamed as safetensors_rust ? | 19:28:41 |
| matthewcroughan | result/lib/python3.11/site-packages/safetensors_rust:
__init__.py __pycache__ safetensors_rust.cpython-311-x86_64-linux-gnu.so
| 19:28:48 |
| K900 | I don't know | 19:29:21 |
| matthewcroughan | hmm nope, tokenizers is a rust binding that is built in the same way, and it is correctly positioned | 19:29:32 |
| matthewcroughan | ls result/lib/python3.11/site-packages/tokenizers
tokenizers/ tokenizers_python-0.14.1.dist-info/
user: matthew 🌐 swordfish in privateGPT on main [!?⇡] is 📦 v0.1.0 via 🐍
✦ ❯ ls result/lib/python3.11/site-packages/tokenizers
__init__.py __pycache__ tokenizers.cpython-311-x86_64-linux-gnu.so
| 19:29:40 |
| K900 | Python package names and module names are not actually required to match | 19:29:43 |
| K900 | As in, a package named safetensors_python can contain modules named safetensors, safetensors_rust or potato | 19:30:08 |
| matthewcroughan | import safetensors_rust
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/nix/store/fbdk8grc3nipn0z5prsfcmvd74pvppaf-python3-3.11.5-env/lib/python3.11/site-packages/safetensors_rust/__init__.py", line 1, in <module>
from .safetensors_rust import *
ImportError: dynamic module does not define module export function (PyInit_safetensors_rust)
| 19:39:54 |
| matthewcroughan | does this tell us anything? | 19:39:57 |
| matthewcroughan | I have no idea how the python binding stuff works | 19:40:28 |
| K900 | It probably tells you the library is very fucked | 19:42:19 |
| matthewcroughan | it seems to compile just fine, and the logs look very similar to transformers which does work correctly | 19:42:34 |
| matthewcroughan | * it seems to compile just fine, and the logs look very similar to transformers which does work correctly and builds in the same way | 19:42:38 |
| matthewcroughan | https://github.com/nixified-ai/flake/blob/master/packages/safetensors/default.nix | 19:43:13 |
