| 27 Oct 2023 |
 @janik0:matrix.org | I have no idea how to pin them to use the same version since the semVersion numbers seem to be the same | 13:21:52 |
 K900 | You want to use the pytestCheckHook from the poetry2nix-created packages set | 13:22:12 |
| @janik0:matrix.org | In reply to @k900:0upti.me
You want to use the pytestCheckHook from the poetry2nix-created packages set how would I access that? | 13:22:43 |
| K900 | That's... a good question, actually | 13:23:31 |
| K900 | I'm not sure we have a good way to actually get to that from inside the package itself | 13:23:43 |
| @janik0:matrix.org | I can also switch to buildPythonPackage from nixpkgs since I'm reworking some parts of the project anyways like adding test and fixing the bug where it tags prs from people that just changed there github name key because of cause I made the mistake of using that instead of the id.. | 13:28:02 |
| @janik0:matrix.org | * I can also just switch to buildPythonPackage from nixpkgs since I'm reworking some parts of the project anyways like adding test and fixing the bug where it tags prs from people that just changed there github name key because of cause I made the mistake of using that instead of the id.. | 13:28:12 |
|  @petrichor:envs.net joined the room. | 18:24:47 |
| 28 Oct 2023 |
 adisbladis | It's not exactly obvious... But I think you could do:
let
drv = poetry2nix.mkPoetryApplication {
nativeBuildInputs = [
drv.passthru.python.pkgs.pytestCheckHook
];
};
in drv
| 03:31:44 |
| adisbladis | In reply to @janik0:matrix.org
how would I access that? ^ | 03:32:16 |
 cpcloud | Looks like pyproject.nix doesn't handle ^4 style constraints | 09:44:40 |
| adisbladis | In reply to @pcloud:matrix.org
Looks like pyproject.nix doesn't handle ^4 style constraints It does: https://nix-community.github.io/pyproject.nix/lib/poetry.html#function-library-lib.poetry.parseVersionCond | 10:01:13 |
| cpcloud | Does it support it in markers? | 10:01:47 |
| cpcloud | like python = "^3.10" | 10:01:54 |
| cpcloud | I'll put up a PR with a test | 10:02:44 |
| cpcloud | Here's an example failure https://github.com/ibis-project/ibis/actions/runs/6673382439/job/18138866562?pr=7455 | 10:03:11 |
| adisbladis | It doesn't support them as a part of pep508 markers, but I don't think that's what we're talking about here. | 10:05:25 |
| adisbladis | These are Python version constraints | 10:05:34 |
| adisbladis | https://github.com/nix-community/poetry2nix/blob/master/mk-poetry-dep.nix#L151 needs to be swapped to the poetry specific one | 10:08:22 |
| adisbladis | cpcloud: https://github.com/nix-community/poetry2nix/pull/1381 | 10:12:17 |
| cpcloud | Nice, thanks | 10:13:03 |
| cpcloud | I will add a test to that PR | 10:14:43 |
| adisbladis | Gotta say I'm pretty happy about how that desugaring turned out | 10:14:45 |
| cpcloud | It does look much nicer | 10:15:28 |
| adisbladis | In reply to @pcloud:matrix.org
I will add a test to that PR Sweet | 10:15:31 |
| adisbladis | Thanks everyone <3 I feel like we're in a much better shape that we've been in in a very long time | 10:17:40 |
| cpcloud | adisbladis: I added the test, it seems to fail in the same way 😕 | 10:23:28 |
| adisbladis | In reply to @pcloud:matrix.org
adisbladis: I added the test, it seems to fail in the same way 😕 Pushed another commit that fixes it =) | 10:26:43 |
| cpcloud | Heh, of course it needs a build-systems fix. Incoming ... | 10:28:47 |
| cpcloud | Ok, test succeeds locally. I set the PR to automerge! Thanks adisbladis | 10:34:18 |
