| 25 Oct 2023 |
K900 | * 2023-10-25T15:27:19.0273590Z python3.11-psutil> In file included from psutil/arch/osx/net.c:12:
2023-10-25T15:27:19.0310490Z python3.11-psutil> /nix/store/z5qnbcqjy7hsvl8q5lr331g5k5rpr312-Libsystem-1238.60.2/include/net/if_dl.h:90:2: error: unknown type name 'u_char'; did you mean 'char'?
2023-10-25T15:27:19.0352800Z python3.11-psutil> u_char sdl_len; /* Total length of sockaddr */
2023-10-25T15:27:19.0363040Z python3.11-psutil> ^
2023-10-25T15:27:19.0377880Z python3.11-psutil> /nix/store/z5qnbcqjy7hsvl8q5lr331g5k5rpr312-Libsystem-1238.60.2/include/net/if_dl.h:91:2: error: unknown type name 'u_char'; did you mean 'char'?
2023-10-25T15:27:19.0399510Z python3.11-psutil> u_char sdl_family; /* AF_LINK */
2023-10-25T15:27:19.0407700Z python3.11-psutil> ^
2023-10-25T15:27:19.0460240Z python3.11-psutil> /nix/store/z5qnbcqjy7hsvl8q5lr331g5k5rpr312-Libsystem-1238.60.2/include/net/if_dl.h:92:2: error: unknown type name 'u_short'; did you mean 'short'?
2023-10-25T15:27:19.0472450Z python3.11-psutil> u_short sdl_index; /* if != 0, system given index for interface */
2023-10-25T15:27:19.0486810Z python3.11-psutil> ^
2023-10-25T15:27:19.0493540Z python3.11-psutil> /nix/store/z5qnbcqjy7hsvl8q5lr331g5k5rpr312-Libsystem-1238.60.2/include/net/if_dl.h:93:2: error: unknown type name 'u_char'; did you mean 'char'?
2023-10-25T15:27:19.0528550Z python3.11-psutil> u_char sdl_type; /* interface type */
2023-10-25T15:27:19.0543290Z python3.11-psutil> ^
2023-10-25T15:27:19.0557360Z python3.11-psutil> /nix/store/z5qnbcqjy7hsvl8q5lr331g5k5rpr312-Libsystem-1238.60.2/include/net/if_dl.h:94:2: error: unknown type name 'u_char'; did you mean 'char'?
2023-10-25T15:27:19.0565710Z python3.11-psutil> u_char sdl_nlen; /* interface name length, no trailing 0 reqd. */
2023-10-25T15:27:19.0604280Z python3.11-psutil> ^
2023-10-25T15:27:19.0641610Z python3.11-psutil> /nix/store/z5qnbcqjy7hsvl8q5lr331g5k5rpr312-Libsystem-1238.60.2/include/net/if_dl.h:95:2: error: unknown type name 'u_char'; did you mean 'char'?
2023-10-25T15:27:19.0644890Z python3.11-psutil> u_char sdl_alen; /* link level address length */
2023-10-25T15:27:19.0650530Z python3.11-psutil> ^
2023-10-25T15:27:19.0652340Z python3.11-psutil> /nix/store/z5qnbcqjy7hsvl8q5lr331g5k5rpr312-Libsystem-1238.60.2/include/net/if_dl.h:96:2: error: unknown type name 'u_char'; did you mean 'char'?
| 15:58:17 |
K900 | This looks very sus | 15:58:26 |
@reckenrode:matrix.org | https://github.com/giampaolo/psutil/compare/release-5.9.5...release-5.9.6 | 15:58:46 |
@reckenrode:matrix.org | Looks like there were a lot of changes to the Mac support. | 15:58:57 |
@reckenrode:matrix.org | I love Python versioning. Patch release? Include a massive refactor. | 15:59:11 |
@reckenrode:matrix.org | Anyway, it’s possible this is tripping over a gap in the source-based SDK. Is it only x86_64-darwin that’s failing to build 5.9.6? I’ve tried to improve the header coverage (e.g., just added missing math.h stuff), but there may be other parts of the source releases that are missing or actually not the right versions (because old headers are released sometimes). | 16:04:10 |
@reckenrode:matrix.org | * Anyway, it’s possible this is tripping over a gap in the source-based SDK. Is it only x86_64-darwin that’s failing to build 5.9.6?
I’ve tried to improve the header coverage (e.g., just added missing math.h stuff), but there may be other parts of the source releases that are missing or actually not the right versions (because old headers are released sometimes).
| 16:04:18 |
@reckenrode:matrix.org | * Anyway, it’s possible this is tripping over a gap in the source-based SDK. Is it only x86_64-darwin that’s failing to build 5.9.6?
I’ve tried to improve the header coverage (e.g., just added missing math.h stuff), but there may be other parts of the source releases that are missing or actually not the right versions (too old).
| 16:04:45 |
K900 | Where are the u_types supposed to be defined? | 16:09:45 |
cpcloud | Randy Eckenrode:
Is it only x86_64-darwin that’s failing to build 5.9.6? That's the only arch we build in poetry2nix CI
| 16:16:43 |
cpcloud | * Randy Eckenrode:
Is it only x86_64-darwin that’s failing to build 5.9.6?
That's the only arch we build in poetry2nix CI
| 16:16:47 |
cpcloud | Since I don't think GitHub provides aarch64-darwin runners | 16:17:11 |
@reckenrode:matrix.org | In reply to @k900:0upti.me Where are the u_types supposed to be defined? Seems to be sys/types.h, which includes some internal headers that define the types. | 16:17:50 |
K900 | But that's an Apple-ism, right? | 16:18:17 |
@reckenrode:matrix.org | It should be included by net/if.h, so I don’t know what’s happening. The 10.12 SDK has those definitions in it. | 16:19:25 |
@reckenrode:matrix.org | You’d have to check what header paths clang is searching. Maybe there’s a bad version of sys/types.h somewhere ahead of Libsystem on the search path. | 16:20:21 |
cpcloud | I can try pinning to 5.9.5, to see if it's related to something inside psutil | 16:20:22 |
cpcloud | No dice on the pinning | 16:42:13 |
@reckenrode:matrix.org | 5.9.5 builds on master and staging. It doesn’t make sense that it would be broken in the poetry2nix CI. | 16:55:53 |
K900 | Could it be a Python version thing somehow | 16:57:02 |
@reckenrode:matrix.org | Staging is Python 3.11, so I wouldn’t think so. | 16:57:45 |
cpcloud | Looks like I wasn't sufficiently pinning (i was trying to not pin on non macos platforms) | 17:37:05 |
cpcloud | With pinning for all platforms psutil builds | 17:37:26 |
cpcloud | torch is the last holdout | 17:37:32 |
cpcloud | Gonna try bumping the torch version too | 18:07:18 |
cpcloud | I honestly have zero idea what sorts of guarantees we should provide given the state of both nixpkgs and python packages. | 18:14:27 |
K900 | I think we just have to resign to doing best effort | 18:17:36 |
cpcloud | tests are green, i ended up just pinning the ml-stack deps | 18:56:05 |
adisbladis | The big green button is pressed | 22:31:45 |
K900 | Woo | 22:33:00 |