| 25 Oct 2023 |
 cpcloud | ah CoreFoundation | 12:52:00 |
 @reckenrode:matrix.org | The Darwin stdenv should include CoreFoundation in its extraBuildInputs. What’s the failure look like? | 12:55:44 |
 K900 | OK I think I'm out of hyperfocus juice | 12:58:42 |
| K900 | I'm going to go get some food | 12:58:46 |
| cpcloud | Randy Eckenrode: https://github.com/nix-community/poetry2nix/actions/runs/6640659859/job/18041541469?pr=1329#step:5:3577 | 13:17:28 |
| cpcloud | I concluded that based on the code in upstream nixpkgs in the psutil drv:
buildInputs =
# workaround for https://github.com/NixOS/nixpkgs/issues/146760
lib.optionals (stdenv.isDarwin && stdenv.isx86_64) [
CoreFoundation
] ++ lib.optionals stdenv.isDarwin [
IOKit
];
| 13:18:30 |
| cpcloud | The poetry2nix error looks like some kind of SDK mismatch | 13:20:19 |
| @reckenrode:matrix.org | In reply to @pcloud:matrix.org
I concluded that based on the code in upstream nixpkgs in the psutil drv:
buildInputs =
# workaround for https://github.com/NixOS/nixpkgs/issues/146760
lib.optionals (stdenv.isDarwin && stdenv.isx86_64) [
CoreFoundation
] ++ lib.optionals stdenv.isDarwin [
IOKit
];
Oh, mixing source-based and system frameworks is usually a bad idea, so I think that PR makes sense. CoreFoundation should probably be added unconditionally though. While aarch64-darwin is currently using system frameworks, that could change in the future. I don’t think that’s the issue though. | 13:21:06 |
| @reckenrode:matrix.org | Weird, header-related problems are usually caused by mixing SDKs in the stdenv. | 13:21:16 |
| @reckenrode:matrix.org | In reply to @pcloud:matrix.org
I concluded that based on the code in upstream nixpkgs in the psutil drv:
buildInputs =
# workaround for https://github.com/NixOS/nixpkgs/issues/146760
lib.optionals (stdenv.isDarwin && stdenv.isx86_64) [
CoreFoundation
] ++ lib.optionals stdenv.isDarwin [
IOKit
];
* Oh, mixing source-based and system frameworks is usually a bad idea, so I think that PR makes sense. CoreFoundation should probably be added unconditionally though. While aarch64-darwin is currently using system frameworks, that could change in the future. I not sure that’s the issue though. | 13:21:42 |
| @reckenrode:matrix.org | But the only build inputs are Darwin frameworks. Huh. | 13:23:32 |
| cpcloud | Could also be a psutil version issue? | 13:24:47 |
| @reckenrode:matrix.org | It doesn’t look like it’s been changed recently though. | 13:25:44 |
| cpcloud | Yeah, hm. | 13:26:20 |
| cpcloud | The runner is using macos-12. Does that matter? | 13:28:16 |
| @reckenrode:matrix.org | I wouldn’t expect it to cause build issues. Something’s wrong with the build environment for psutil. | 13:29:30 |
| @reckenrode:matrix.org | Redacted or Malformed Event | 13:31:54 |
| @reckenrode:matrix.org | * Hmm. python3Packages.psutil builds on staging. | 13:31:59 |
| @reckenrode:matrix.org | It builds on master. aarch64-darwin builds on staging. I still need to build a few dependencies for x86_64-darwin. | 13:34:28 |
| cpcloud | Hm, maybe we need to wait for nixos-unstable-small updates (or patch in whatever's on master ) | 13:36:12 |
| cpcloud | * Hm, maybe we need to wait for nixos-unstable-small updates (or patch in whatever's on master) | 13:36:14 |
| cpcloud | 😬
❯ gl HEAD..upstream/master --oneline --no-merges | wc -l
678
| 13:37:06 |
| @reckenrode:matrix.org | The build finally finished, so I can also confirm that it builds on staging as well (both aarch64-darwin and x86_64-darwin). | 14:43:18 |
| @reckenrode:matrix.org | * The build finally finished, so I can also confirm that it builds on staging as well (both aarch64 and x86_64). | 14:43:33 |
| @reckenrode:matrix.org | * The build finally finished, so I can also confirm that psutil builds on staging (both aarch64 and x86_64). | 14:43:53 |
| cpcloud | So I guess that means waiting for nixos-unstable-small to be updated, unless someone knows what to cherry pick to fix the issue | 14:43:55 |
| cpcloud | Or, there's something else going on in poetry2nix... | 14:44:18 |
| @reckenrode:matrix.org | The override for psutil is just adding IOKit again. I don’t know how that could cause problems. They both should be using the same SDK version (nixpkgs and poetry2nix’s overrides). | 14:45:31 |
| @reckenrode:matrix.org | * The override in poetry2nix for psutil is just adding IOKit again. I don’t know how that could cause problems. They both should be using the same SDK version (nixpkgs and poetry2nix’s overrides). | 14:45:41 |
| @reckenrode:matrix.org | * The override in poetry2nix for psutil is just adding IOKit again. I don’t think that should cause problems. They both should be using the same SDK version (nixpkgs and poetry2nix’s overrides). | 14:46:26 |
