| 25 Oct 2023 |
 cpcloud | Pretty sure it's broken on nixos-unstable-small and not related to poetry2nix | 11:37:59 |
|  @reckenrode:matrix.org joined the room. | 11:39:54 |
 K900 | @Randy Eckenrode is the nixpkgs Darwin expert person | 11:41:58 |
| K900 | Who I dragged here to help | 11:42:02 |
| cpcloud | Thanks. There are a couple other failures too which I am looking into | 11:42:41 |
| @reckenrode:matrix.org | In reply to @pcloud:matrix.org
The mac os issue is that netcdf is failing to link libhdf5_hl https://github.com/nix-community/poetry2nix/actions/runs/6638146548/job/18038264309#step:5:5781 It’s not Python-related. I submitted a PR last month to fix the build with clang 16. It was building at the time, so I don’t know what broke it. | 11:42:45 |
| @reckenrode:matrix.org | Well, probably not Python-related. | 11:42:53 |
| @reckenrode:matrix.org | I’m building it now to see if I can figure out what happened and fix it. | 11:43:28 |
| cpcloud | Ok, I got pandas build on osx ci, the remaining failures are the pytorch from the ml-stack test, psutil, and netcdf | 12:22:22 |
| K900 | Does torch even work on OSX | 12:35:12 |
| cpcloud | It builds on master | 12:48:00 |
| cpcloud | the psutil issue looks like it might be a 3.11 issue. I'm going to see about changing python3 to python310 in that test | 12:49:40 |
| cpcloud | Ok, nevermind, that's running python 3.9 :) | 12:50:11 |
| cpcloud | nix build 'nixpkgs#python39Packages.psutil' --system x86_64-darwin works for me, so maybe there's some adjustment needed on the p2nix side overrides | 12:50:54 |
| cpcloud | ah CoreFoundation | 12:52:00 |
| @reckenrode:matrix.org | The Darwin stdenv should include CoreFoundation in its extraBuildInputs. What’s the failure look like? | 12:55:44 |
| K900 | OK I think I'm out of hyperfocus juice | 12:58:42 |
| K900 | I'm going to go get some food | 12:58:46 |
| cpcloud | Randy Eckenrode: https://github.com/nix-community/poetry2nix/actions/runs/6640659859/job/18041541469?pr=1329#step:5:3577 | 13:17:28 |
| cpcloud | I concluded that based on the code in upstream nixpkgs in the psutil drv:
buildInputs =
# workaround for https://github.com/NixOS/nixpkgs/issues/146760
lib.optionals (stdenv.isDarwin && stdenv.isx86_64) [
CoreFoundation
] ++ lib.optionals stdenv.isDarwin [
IOKit
];
| 13:18:30 |
| cpcloud | The poetry2nix error looks like some kind of SDK mismatch | 13:20:19 |
| @reckenrode:matrix.org | In reply to @pcloud:matrix.org
I concluded that based on the code in upstream nixpkgs in the psutil drv:
buildInputs =
# workaround for https://github.com/NixOS/nixpkgs/issues/146760
lib.optionals (stdenv.isDarwin && stdenv.isx86_64) [
CoreFoundation
] ++ lib.optionals stdenv.isDarwin [
IOKit
];
Oh, mixing source-based and system frameworks is usually a bad idea, so I think that PR makes sense. CoreFoundation should probably be added unconditionally though. While aarch64-darwin is currently using system frameworks, that could change in the future. I don’t think that’s the issue though. | 13:21:06 |
| @reckenrode:matrix.org | Weird, header-related problems are usually caused by mixing SDKs in the stdenv. | 13:21:16 |
| @reckenrode:matrix.org | In reply to @pcloud:matrix.org
I concluded that based on the code in upstream nixpkgs in the psutil drv:
buildInputs =
# workaround for https://github.com/NixOS/nixpkgs/issues/146760
lib.optionals (stdenv.isDarwin && stdenv.isx86_64) [
CoreFoundation
] ++ lib.optionals stdenv.isDarwin [
IOKit
];
* Oh, mixing source-based and system frameworks is usually a bad idea, so I think that PR makes sense. CoreFoundation should probably be added unconditionally though. While aarch64-darwin is currently using system frameworks, that could change in the future. I not sure that’s the issue though. | 13:21:42 |
| @reckenrode:matrix.org | But the only build inputs are Darwin frameworks. Huh. | 13:23:32 |
| cpcloud | Could also be a psutil version issue? | 13:24:47 |
| @reckenrode:matrix.org | It doesn’t look like it’s been changed recently though. | 13:25:44 |
| cpcloud | Yeah, hm. | 13:26:20 |
| cpcloud | The runner is using macos-12. Does that matter? | 13:28:16 |
| @reckenrode:matrix.org | I wouldn’t expect it to cause build issues. Something’s wrong with the build environment for psutil. | 13:29:30 |
