| 25 Oct 2023 |
K900 | Like, it should be adding a thunk | 11:21:56 |
K900 | Not fully evaluating it | 11:22:10 |
K900 | So you can just removePackagesByName it away later | 11:22:15 |
cpcloud | I am using lib.remove, maybe that's the reason? | 11:23:25 |
K900 | lib.remove what? | 11:23:30 |
cpcloud |
sphinxcontrib-applehelp = super.sphinxcontrib-applehelp.overridePythonAttrs (old: {
propagatedBuildInputs = lib.remove self.sphinx old.propagatedBuildInputs;
});
| 11:23:46 |
cpcloud | * sphinxcontrib-applehelp = super.sphinxcontrib-applehelp.overridePythonAttrs (old: {
propagatedBuildInputs = lib.remove self.sphinx old.propagatedBuildInputs;
});
| 11:23:50 |
K900 | Yeah it won't compare equal probably | 11:25:01 |
cpcloud | Lemme try the other function | 11:25:10 |
K900 | Because drvs aren't compared sanely | 11:25:12 |
cpcloud | Ok, nice that gets the eval working, thank you! | 11:28:19 |
cpcloud | sphinxcontrib-serializinghtml = super.sphinxcontrib-serializinghtml.overridePythonAttrs (old: {
propagatedBuildInputs = removePackagesByName (old.propagatedBuildInputs or [ ]) [ self.sphinx ];
});
| 11:28:31 |
cpcloud | I'll push up the fixes and a test once I update build-systems.json to get things working | 11:29:23 |
K900 | Cool | 11:29:26 |
cpcloud | pushed | 11:31:16 |
cpcloud | The mac os issue is that netcdf is failing to link libhdf5_hl https://github.com/nix-community/poetry2nix/actions/runs/6638146548/job/18038264309#step:5:5781 | 11:34:33 |
cpcloud | Pretty sure it's broken on nixos-unstable-small and not related to poetry2nix | 11:37:59 |
| @reckenrode:matrix.org joined the room. | 11:39:54 |
K900 | @Randy Eckenrode is the nixpkgs Darwin expert person | 11:41:58 |
K900 | Who I dragged here to help | 11:42:02 |
cpcloud | Thanks. There are a couple other failures too which I am looking into | 11:42:41 |
@reckenrode:matrix.org | In reply to @pcloud:matrix.org The mac os issue is that netcdf is failing to link libhdf5_hl https://github.com/nix-community/poetry2nix/actions/runs/6638146548/job/18038264309#step:5:5781 It’s not Python-related. I submitted a PR last month to fix the build with clang 16. It was building at the time, so I don’t know what broke it. | 11:42:45 |
@reckenrode:matrix.org | Well, probably not Python-related. | 11:42:53 |
@reckenrode:matrix.org | I’m building it now to see if I can figure out what happened and fix it. | 11:43:28 |
cpcloud | Ok, I got pandas build on osx ci, the remaining failures are the pytorch from the ml-stack test, psutil, and netcdf | 12:22:22 |
K900 | Does torch even work on OSX | 12:35:12 |
cpcloud | It builds on master | 12:48:00 |
cpcloud | the psutil issue looks like it might be a 3.11 issue. I'm going to see about changing python3 to python310 in that test | 12:49:40 |
cpcloud | Ok, nevermind, that's running python 3.9 :) | 12:50:11 |
cpcloud | nix build 'nixpkgs#python39Packages.psutil' --system x86_64-darwin works for me, so maybe there's some adjustment needed on the p2nix side overrides | 12:50:54 |