| 8 Nov 2023 |
 adisbladis | It's funny that they don't even publish sdists but still have cmake listed :P | 22:24:16 |
 matthewcroughan | ah, apparently I do need cmake for another reason | 22:25:43 |
| matthewcroughan | oh nvm, I just am too dumb to know what you mean by filtering it | 22:26:12 |
| adisbladis | propagatedBuildInputs = builtins.filter (e: e.pname != "cmake") old.propagatedBuildInputs; | 22:26:45 |
| matthewcroughan | yeah that's what I did | 22:27:10 |
| matthewcroughan | guess it's not in propagated, native maybe | 22:27:14 |
| matthewcroughan | https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/development/python-modules/openai-triton/default.nix#L150 | 22:28:49 |
| matthewcroughan | openai-triton won't be being used by the overlay though, since of the naming mismatch | 22:29:07 |
| matthewcroughan | even though I think this is the correct one | 22:29:14 |
| adisbladis | They do source builds https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/development/python-modules/openai-triton/default.nix#L57-L62 | 22:29:33 |
| adisbladis | So it's correct for them to have cmake | 22:29:38 |
| matthewcroughan | right, so I do need cmake, and I need to fix cmake | 22:29:55 |
| adisbladis | No, you don't | 22:30:12 |
| adisbladis | Cmake is something you need when building from source | 22:30:19 |
| matthewcroughan | and in this case I have a dist but it is still trying to use cmake, and I'm trying to get rid of cmake | 22:30:36 |
| adisbladis | Upstream has some buggy dependency definitions, like all other crappy "data science" packages | 22:30:44 |
| matthewcroughan | it's not in the propagatedBuildInputs, and I can't remove it from native because something in the list doesn't have pname | 22:30:51 |
| adisbladis | The thing in the list that doesn't have pname is probably cmake which you just set to null | 22:31:18 |
| adisbladis | matthewcroughan - nix.how: I think you'd benefit from calming down a bit and try and understand why the dependencies exist | 22:31:52 |
| matthewcroughan | I'm not angry? Lol | 22:31:58 |
| adisbladis | No, but very hurried | 22:32:04 |
| matthewcroughan | Do you blame me? Is Python calming for you? | 22:32:31 |
| matthewcroughan | I had this thing working, then I found out about poetry groups, now I have 10 more overrides to make :D | 22:33:00 |
| adisbladis | I think the dependency relations here are fairly obvious, and so is the fix | 22:33:00 |
| matthewcroughan | you can't set cmake to null because then it makes the filter function fail in the poetry overrides, this is a tricky one for me | 22:36:25 |
| matthewcroughan | cmake = null;
triton = super.triton.overridePythonAttrs
(
old: {
propagatedBuildInputs = builtins.filter (e: e != null) old.propagatedBuildInputs;
dontUseCmakeConfigure = true;
}
);
| 22:36:44 |
| adisbladis | That will fail with the same error message because of the bundled poetry2nix overrides | 22:37:26 |
| matthewcroughan | that's what I am suggesting | 22:37:35 |
| adisbladis | Remove cmake = null & do:
propagatedBuildInputs = builtins.filter (e: e.pname != "cmake") old.propagatedBuildInputs;
| 22:38:20 |
| matthewcroughan | Oh, that's what I originally did | 22:38:45 |
