| 8 Nov 2023 |
 matthewcroughan | * adisbladis: check out my overrides in the flake here
https://github.com/MatthewCroughan/privateGPT/blob/main/flake.nix#L25-L145
| 22:07:34 |
| matthewcroughan | it's a loooooot of them, maybe useful for poetry2nix's overrides | 22:07:42 |
| matthewcroughan | a lot of vendoring the cargo.locks, even though the upstream src has a lock. | 22:08:04 |
 adisbladis | https://github.com/MatthewCroughan/privateGPT/blob/main/flake.nix#L34 | 22:08:09 |
| adisbladis | At least that would explain the setup hook error | 22:09:11 |
| matthewcroughan | Did I do something wrong there? | 22:10:03 |
| adisbladis | Why are you adding cmake? | 22:10:14 |
| matthewcroughan | it said cmake not found | 22:10:24 |
| matthewcroughan | If I remove that override:
Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing wheel setup hook
Using wheelUnpackPhase
Sourcing pypa-install-hook
Using pypaInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
Sourcing python-catch-conflicts-hook.sh
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
Executing wheelUnpackPhase
Finished executing wheelUnpackPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Relea>
/nix/store/nid28g9ivpg8lvc6wk8na8mzxzyhqw8m-python3.11-cmake-3.26.4/nix-support/setup-hook: line 126: cmake: command not found
lines 1-24/24 (END)
| 22:10:53 |
| adisbladis | It's almost 100% doing that because you added the override | 22:11:11 |
| matthewcroughan | well I removed the override, and the above log is what I get | 22:11:23 |
| matthewcroughan | diff --git a/flake.nix b/flake.nix
index 6ed975e..9425b45 100644
--- a/flake.nix
+++ b/flake.nix
@@ -28,12 +28,6 @@
chroma-hnswlib = super.chroma-hnswlib.override { preferWheel = true; };
chromadb = super.chromadb.override { preferWheel = true; };
cmake = pkgs.python3Packages.cmake;
- triton = super.triton.overridePythonAttrs
- (
- old: {
- nativeBuildInputs = (old.nativeBuildInputs or [ ]) ++ [ self.cmake ];
- }
- );
gradio = super.gradio.overridePythonAttrs
(
old: {
| 22:11:33 |
| adisbladis | Which you don't actually want to do, least of which because upstream doesn't actually ship sdists: https://github.com/imartinez/privateGPT/blob/main/poetry.lock#L4598-L4617 | 22:11:35 |
| adisbladis | Only wheels | 22:11:37 |
| adisbladis | We don't have any overrides in poetry2nix adding cmake to triton, so idk what you're doing | 22:12:41 |
| adisbladis | Also this is 100% wrong https://github.com/MatthewCroughan/privateGPT/blob/main/flake.nix#L30 | 22:12:47 |
| adisbladis | And will cause shit to explode | 22:12:53 |
| adisbladis | Never ever reference an outside python package set | 22:13:01 |
| matthewcroughan | oh, it made everything else compile, hah | 22:13:05 |
| matthewcroughan | python3.11-cmake> obj = import_module(mod_path)
python3.11-cmake> ^^^^^^^^^^^^^^^^^^^^^^^
python3.11-cmake> File "/nix/store/ffll6glz3gwx342z0ch8wx30p5cnqz1z-python3-3.11.5/lib/python3.11/importlib/__init__.py", line 126, in import_module
python3.11-cmake> return _bootstrap._gcd_import(name[level:], package, level)
python3.11-cmake> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
python3.11-cmake> File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
python3.11-cmake> File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
python3.11-cmake> File "<frozen importlib._bootstrap>", line 1126, in _find_and_load_unlocked
python3.11-cmake> File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
python3.11-cmake> File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
python3.11-cmake> File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
python3.11-cmake> File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
python3.11-cmake> ModuleNotFoundError: No module named 'setuptools'
python3.11-cmake>
python3.11-cmake>
| 22:13:28 |
| matthewcroughan | if I remove it, something depends on it, and cmake itself fails like this | 22:13:37 |
| matthewcroughan | I add setuptools, it requires cmake binary, etc | 22:13:44 |
| matthewcroughan | https://github.com/nix-community/poetry2nix/pull/1132 | 22:13:53 |
| matthewcroughan | it's depending on this PR | 22:13:57 |
| matthewcroughan | I copied what's in this PR, but was still unable to get anywhere, because I need a newer one, and the challenges I faced seemed too hard | 22:14:29 |
| matthewcroughan | so I referenced the outside python package set, and that made everything compile | 22:14:50 |
| adisbladis | You need to start by fixing that, because with that there the whole thing is cursed | 22:15:13 |
| adisbladis | And for that cmake issue look into dontUseCmakeConfigure | 22:16:56 |
| adisbladis | Idk where you're getting cmake from or how the hook enters the build | 22:17:28 |
| matthewcroughan | it's in the poetry.lock of privateGPT | 22:18:13 |
