| 20 Apr 2024 |
| Roland Coeurjoly joined the room. | 14:50:15 |
Roland Coeurjoly | In reply to @vengmark2:matrix.org
- Absolutely. There are far too many packages for any individual to keep track of all the non-Python dependencies and missing dependencies.
- Generally, yes, but if that's too much work simply having the dependencies at all is better than not having them.
- If you can, that would be great. Splitting your work into multiple PRs would be appreciated, though, since the difficulty of reviewing scales by something like O(N²) for N lines.
Questions about buildSystem:
"urllib3": [ "setuptools", { "buildSystem": "flit-core", "until": "2.0.2" }, { "buildSystem": "hatchling", "from": "2.0.2" } ],
| 15:22:51 |
Roland Coeurjoly | In reply to @vengmark2:matrix.org
- Absolutely. There are far too many packages for any individual to keep track of all the non-Python dependencies and missing dependencies.
- Generally, yes, but if that's too much work simply having the dependencies at all is better than not having them.
- If you can, that would be great. Splitting your work into multiple PRs would be appreciated, though, since the difficulty of reviewing scales by something like O(N²) for N lines.
* Questions about buildSystem: Given the following: "urllib3": [ "setuptools", { "buildSystem": "flit-core", "until": "2.0.2" }, { "buildSystem": "hatchling", "from": "2.0.2" } ], | 15:23:12 |
Roland Coeurjoly | * Questions about buildSystem: Given the following: "urllib3": [ "setuptools", { "buildSystem": "flit-core", "until": "2.0.2" }, { "buildSystem": "hatchling", "from": "2.0.2" } ],
If I build 2.0.2, does it pull setuptools too?
| 15:23:51 |
K900 | Yes | 15:25:18 |
K900 | It needs to be set with until and/or from to be conditional | 15:25:28 |
Roland Coeurjoly | In reply to @k900:0upti.me It needs to be set with until and/or from to be conditional Thanks. Also, if I have
"my_package": [ { "buildSystem": "flit-core", "from": "2.0.1" }, { "buildSystem": "hatchling", "from": "2.0.2" } ],
If I build 2.0.2, does it pull flit-core?
| 15:30:46 |
K900 | Yes | 15:31:04 |
K900 | None of those are exclusive | 15:31:09 |
K900 | Every item is checked completely separately | 15:31:14 |
K900 | And added if it applies | 15:31:17 |
Roland Coeurjoly | great, thank you. | 16:11:32 |
Roland Coeurjoly | I just pushed a PR fixing one of the failling tests, git-deps | 16:11:52 |
Roland Coeurjoly | there are now 15 failing tests, from 16 | 16:12:25 |
| 21 Apr 2024 |
Roland Coeurjoly | And some other PRs too, let me know if there is any question | 07:42:36 |
| 22 Apr 2024 |
| @malteneuss:matrix.org joined the room. | 06:20:57 |
@malteneuss:matrix.org | Ah i just found this dedicated room. At my company we are trying out Nix with our Python services and a few people are struggling with some areas of poetry2nix. That's why i decided to improve the documentation: K900 Do you who know i can ping for some documentation improvement MRs for poetry2nix like https://github.com/nix-community/poetry2nix/pull/1600 Maybe you? adisbladis seems to be busy, and i couldn't find any other listed maintainer. | 06:23:59 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | This should probably get a merge https://github.com/nix-community/poetry2nix/pull/1600 | 20:13:57 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Actually, this code doesn't work in flakes. | 21:34:36 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | https://github.com/nix-community/poetry2nix/blob/master/vendor/pyproject.nix/fetchers/default.nix#L112-L116 | 21:34:50 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | pathParts = filter ({ prefix, path }: "NETRC" == prefix) nixPath; # deadnix: skip
netrc_file =
if (pathParts != [ ])
then (head pathParts).path
else "";
| 21:34:59 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | netrc_file is always "" because nixPath is always [] in pure-eval | 21:35:17 |
| @niklauzg:matrix.org left the room. | 23:53:48 |
| 23 Apr 2024 |
| nim65s changed their display name from Guilhem to nim65s. | 07:52:33 |
truh | Does it need to be that strict in fixed output derivations? Private git repos work too. | 09:49:56 |
@malteneuss:matrix.org | In reply to @matthewcroughan:defenestrate.it
netrc_file is always "" because nixPath is always [] in pure-eval Thanks for the feedback. The Nix flake variant indeed was missing in my PR. I added a few paragraphs how to add env vars to the nix-daemon (i think this is the only working way for flakes). Could you take a look again?
btw, thanks for your awesome talks on Nix for Docker (the main reason my company is willing to try Nix) and for Riscv.
| 19:55:13 |
@malteneuss:matrix.org | In reply to @truh:matrix.org Does it need to be that strict in fixed output derivations? Private git repos work too. According to my current understanding the correct way is to not let code inside the sandbox fetch things with credentials (due to security concerns) but let nix do that outside of the sandbox. I think there are some special builtins.fetchers that can take care of that. I may take a look at this once our Python backend services run with poetry2nix and Docker. | 19:59:28 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | In reply to @malteneuss:matrix.org
Thanks for the feedback. The Nix flake variant indeed was missing in my PR. I added a few paragraphs how to add env vars to the nix-daemon (i think this is the only working way for flakes). Could you take a look again?
btw, thanks for your awesome talks on Nix for Docker (the main reason my company is willing to try Nix) and for Riscv.
Thanks! | 21:59:21 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | No, I believe there is no way to pass the NETRC file in, even following your documentation, because poetry2nix has the above bug in it that makes stuff only work via -I which isn't available in pure-eval. | 21:59:48 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | I'm triple checking that here | 21:59:55 |