Poetry2nix | 330 Members | |
| https://github.com/nix-community/poetry2nix | 62 Servers |
| Sender | Message | Time |
|---|---|---|
| 14 Aug 2022 | ||
| Generally yes | 14:51:00 | |
| Where can I store these patch files? I'm getting
| 14:56:00 | |
| You need to add it to git | 14:56:12 | |
| For it to work | 14:56:14 | |
| Perfect! That worked. Thank you. | 14:56:35 | |
I am not 100% sure this is a nix issue but tensorstore/bazelisk.py seems to be trying to download bazel right here: https://github.com/google/tensorstore/blob/fd14f04c33620645da94667c4fa860b258417dcf/bazelisk.py#L449 | 15:08:28 | |
| We then get this error:
| 15:09:10 | |
| That is normal, the build sandbox has no network | 15:09:18 | |
| Right ok that makes sense | 15:09:27 | |
| So in that case, would it be best to write a patch that uses the nix bazel instead of downloading a new one? | 15:09:55 | |
| Can you tell it to use an existing copy of bazel somehow? | 15:10:03 | |
| Let me play around with it. Should be possible. Thanks. | 15:10:25 | |
| We have a bazel in nixpkgs | 15:10:49 | |
If I were to write a patch that points to that bazel instead, how would I get the /nix/store/.../bazel path? | 15:11:32 | |
${bazel}/bin/bazel | 15:11:59 | |
| But you can't do that in the patch | 15:12:05 | |
Usually you want to patch it to a placeholder like @bazel@ and then substituteInPlace to set it to the actual value | 15:12:44 | |
| What phase would you recommend for that? | 15:15:22 | |
postPatch? | 15:15:31 | |
| Yes | 15:19:28 | |
| Redacted or Malformed Event | 15:21:10 | |
| * This is what I have but it is not performing the replacement correctly:
| 15:21:25 | |
| Redacted or Malformed Event | 15:21:27 | |
| Ok I think we fixed that error! | 15:22:37 | |
| We are now getting:
| 15:22:57 | |
| I can look into this a bit | 15:23:00 | |
I was able to get past a few more errors, but started running into weird issues with bazel and perl. However I think I may not actually need the tensorstore package after all. | 15:59:02 | |
What I really wanted was the flax library which can work without tensorstore though it disables one minor feature. | 15:59:28 | |
Poetry thinks thinks that tensorstore is a dependency of flax but I was wondering if there was a correct way, via poetry2nix to tell it to ignore tensorstore. Should I patch poetry.lock? | 16:00:30 | |
I will work on a pull request for tensorstore, just need to learn a little more about bazel. Thanks for all your help @K900. | 19:30:56 | |