| 16 Feb 2022 |
 K900 | And this is a Python thing, not really a Nix thing | 20:24:24 |
 worldofgeese | In reply to @k900:0upti.me
You need to actually declare that the file should be installed It is in site-packages, if you look at the second command I put | 20:26:00 |
| K900 | Oh, I see | 20:26:44 |
| K900 | Your path is wrong for two reasons | 20:26:52 |
| K900 | 1) you're looking one folder above the current directory, when the file is in the same directory as your Python code | 20:27:12 |
| K900 | And 2) open works relative to current working directory, not source file location | 20:27:35 |
| K900 | The actually correct way to do this would be https://docs.python.org/3/library/importlib.html#module-importlib.resources | 20:29:08 |
| worldofgeese | This is what I thought! But poetry run lbob actually wants the source directory path. Here's what I wrote in this commit explaining the choice:
Poetry has odd behavior around relative file paths. Python scripts must
import starting from the project (`little_bits_of_buddha`) even if they
occupy the same directory. This commit fixes file paths to operate from
"project in".
| 20:29:24 |
| worldofgeese | Of course I admit my thinking could be wrong here but I couldn't argue with the results | 20:29:37 |
| worldofgeese | As poetry run lbob and the Nix derivation both run successfully | 20:29:49 |
| K900 | So you fixed issue #1, kind of | 20:31:13 |
| K900 | But you still have issue #2 | 20:31:19 |
| K900 | The easy way out would be to do something like pathlib.Path(__file__) / "../data.json" | 20:31:50 |
| K900 | The correct way out would be to use importlib.resources | 20:32:05 |
| worldofgeese | Interesting. Can you give me an example of how I would use importlib.resources in this case? | 20:32:40 |
| K900 | Basically just from importlib import resources; resources.files("your_package_name").join("data.json").read_text() | 20:34:19 |
| worldofgeese | From inside my data.py file right? It would replace the open() | 20:35:20 |
| K900 | It would replace the whole thing | 20:35:52 |
| worldofgeese | This is my first real Python project, sorry if my questions are very amateur | 20:36:03 |
| K900 | You probably want to then pass the result to json.loads | 20:36:04 |
| K900 | Also, you might want to move that out of the function | 20:36:43 |
| K900 | Because importlib will be slower than just reading the file off the disk | 20:37:00 |
| K900 | Probably not by enough for it to mattrr | 20:37:10 |
| K900 | * Probably not by enough for it to matter | 20:37:13 |
| K900 | But it's generally good practice to load resources once and then keep them in memory | 20:37:26 |
| K900 | Because your project could be installed as a wheel, or as an egg, or as whatever other weird format whatever other weird Python implementation uses | 20:38:02 |
| worldofgeese | Wow, this is really helpful, thank you for taking the time with me! I will try and implement your suggestions and see if I can marshal it into some form of life | 20:39:54 |
| worldofgeese | * Wow, this is really helpful, thank you for taking the time with me! I will try and implement your suggestions and see if I can marshal my application into some form of life | 20:43:18 |
|  asymmetric left the room. | 22:08:54 |
| 17 Feb 2022 |
| worldofgeese | I've changed the code of data.py to access the package resource data.json like so:
from importlib import resources
with resources.open_text("little_bits_of_buddha", "data.json") as json_file:
data = json.load(json_file)
def random_sutta():
attributed_quotes = []
for collection in data["collection"].values():
for quote in collection.values():
attributed_quotes.append(quote)
return random.choice(attributed_quotes)
which again works with poetry run lbob and nix build && ./result/bin/lbob but continues to give errors accessing the resource from inside dockerTools.streamLayeredImage produced image:
File "/nix/store/y3i0wgxmwc9l2r5a167isx4bnpsm4fih-python3.9-little-bits-of-buddha-0.1.0/lib/python3.9/site-packages/little_bits_of_buddha/data.py", line 7, in <module>
with resources.open_text(__package__, "data.json") as json_file:
File "/nix/store/i6vabb4div9iy6lsl642d86k1q8riasn-python3-3.9.9/lib/python3.9/importlib/resources.py", line 121, in open_text
open_binary(package, resource), encoding=encoding, errors=errors)
File "/nix/store/i6vabb4div9iy6lsl642d86k1q8riasn-python3-3.9.9/lib/python3.9/importlib/resources.py", line 111, in open_binary
raise FileNotFoundError(message)
FileNotFoundError: 'data.json' resource not found in 'little_bits_of_buddha'
| 07:39:15 |
