!rWxyQqNqMUDLECdsIf:blad.is

Poetry2nix

330 Members
https://github.com/nix-community/poetry2nix62 Servers

Load older messages


SenderMessageTime
25 Aug 2022
@ethanabrooks:matrix.orgEthan BrooksIs that what I currently have?12:19:33
@bryan.bennett:matrix.orgBryanNo idea - I don't have your current work.12:19:44
@bryan.bennett:matrix.orgBryan But maybe. depends on where you set doCheck = False. If you did it in the override for clu, then yes. 12:20:24
@bryan.bennett:matrix.orgBryan There is also a list of dependencies that are only necessary for the check phase, if that interests you. You could set that, get pytorch to get the tests passing and then drop it from the final closure. 12:21:15
@ethanabrooks:matrix.orgEthan Brooks
        clu = pyprev.buildPythonPackage rec {
          pname = "clu";
          version = "0.0.7";
          src = pyprev.fetchPypi {
            inherit pname version;
            sha256 = "sha256-RJqa8XnDpcRPwYlH+4RKAOos0x4+3hMWf/bv6JNn2ys=";
          };
          doCheck = false;
          buildInputs = with pyfinal; [
            absl-py
            cached-property
            etils
            flax
            jax
            jaxlib
            ml-collections
            numpy
            packaging
            tensorflow
            tensorflow-datasets
          ];
        };
12:22:24
@ethanabrooks:matrix.orgEthan BrooksWhat is the key for check-only dependencies?12:22:47
@bryan.bennett:matrix.orgBryan
In reply to @ethanabrooks:matrix.org
What is the key for check-only dependencies?

Missed this message. Sorry!

I don't recall offhand.
I'll try and figure it out in a moment.

13:16:00
@adis:blad.isadisbladis It's checkInputs 13:16:20
@adis:blad.isadisbladis Ethan Brooks: 13:16:28
@bryan.bennett:matrix.orgBryan^ That. Just found it in nixpkgs.13:19:00
@bryan.bennett:matrix.orgBryanhttps://github.com/NixOS/nixpkgs/blob/350fd0044447ae8712392c6b212a18bdf2433e71/pkgs/development/interpreters/python/mk-python-derivation.nix#L4013:19:09
@ethanabrooks:matrix.orgEthan BrooksGot it. Thank you.16:00:54
@ethanabrooks:matrix.orgEthan BrooksShould I put together a pull request for nixpkgs or poetry2nix?16:01:06
@ethanabrooks:matrix.orgEthan BrooksHappy to contribute when I can.16:01:12
@bryan.bennett:matrix.orgBryan

Depends on how you solved it.
If you added torch to checkInputs, maybe add it to the default overrides in poetry2nix.

I don't think you need to worry if you ultimately just disabled the tests for clu.

I don't see a way that this would lead you to nixpkgs in either case though (you're modifying a derivation that poetry2nix creates, not one from nixpkgs).\

17:33:43
26 Aug 2022
@luctielen:matrix.orgLuc Tielen left the room.22:01:32
30 Aug 2022
@aruzeta:matrix.orgaru joined the room.14:41:56
@aruzeta:matrix.orgaru left the room.14:54:00
31 Aug 2022
@collinarnett:matrix.orgCollin Arnetthttps://github.com/python-poetry/poetry/releases/tag/1.2.011:26:38
@collinarnett:matrix.orgCollin ArnettBoom11:26:41
@adis:blad.isadisbladis

I'm unlikely to have time to look into supporting the new pyproject.toml syntax any time soon (see that as a call to action).

Patches very welcome.

11:51:58
@adis:blad.isadisbladisNot sure what we'll do with dependency groups yet.11:52:11
1 Sep 2022
@adis:blad.isadisbladisGot the ball rolling: https://github.com/nix-community/poetry2nix/pull/70415:34:59
@adis:blad.isadisbladisAand it seems that we're up to parity with older Poetry versions16:26:37
@adis:blad.isadisbladisIt does however depend on a nixpkgs change that has to propagate out in the channels16:26:57
@adis:blad.isadisbladis For now I'm ignoring dependency groups other than dev 16:27:21
2 Sep 2022
@adis:blad.isadisbladisAnother update on dependency groups: They are now supported in https://github.com/nix-community/poetry2nix/pull/704 and tests pass if I point nixpkgs to my local checkout based on master03:02:42
@adis:blad.isadisbladisWe're just awaiting https://github.com/NixOS/nixpkgs/pull/187999 + the backport to hit the channels and then I'll merge 1.2.003:04:09
5 Sep 2022
@kotatsuyaki:matrix.orgkotatsuyaki joined the room.05:06:02
@pederbs:pvv.ntnu.nopbsdsDoes poetry2nix also support the lockfiles of pdm?08:22:38

Show newer messages


Back to Room ListRoom Version: 6