| 25 Aug 2022 |
Ethan Brooks | Is that what I currently have? | 12:19:33 |
Bryan | No idea - I don't have your current work. | 12:19:44 |
Bryan | But maybe. depends on where you set doCheck = False. If you did it in the override for clu, then yes. | 12:20:24 |
Bryan | There is also a list of dependencies that are only necessary for the check phase, if that interests you. You could set that, get pytorch to get the tests passing and then drop it from the final closure. | 12:21:15 |
Ethan Brooks | clu = pyprev.buildPythonPackage rec {
pname = "clu";
version = "0.0.7";
src = pyprev.fetchPypi {
inherit pname version;
sha256 = "sha256-RJqa8XnDpcRPwYlH+4RKAOos0x4+3hMWf/bv6JNn2ys=";
};
doCheck = false;
buildInputs = with pyfinal; [
absl-py
cached-property
etils
flax
jax
jaxlib
ml-collections
numpy
packaging
tensorflow
tensorflow-datasets
];
};
| 12:22:24 |
Ethan Brooks | What is the key for check-only dependencies? | 12:22:47 |
Bryan | In reply to @ethanabrooks:matrix.org What is the key for check-only dependencies? Missed this message. Sorry!
I don't recall offhand. I'll try and figure it out in a moment.
| 13:16:00 |
adisbladis | It's checkInputs | 13:16:20 |
adisbladis | Ethan Brooks: | 13:16:28 |
Bryan | ^ That. Just found it in nixpkgs. | 13:19:00 |
Bryan | https://github.com/NixOS/nixpkgs/blob/350fd0044447ae8712392c6b212a18bdf2433e71/pkgs/development/interpreters/python/mk-python-derivation.nix#L40 | 13:19:09 |
Ethan Brooks | Got it. Thank you. | 16:00:54 |
Ethan Brooks | Should I put together a pull request for nixpkgs or poetry2nix? | 16:01:06 |
Ethan Brooks | Happy to contribute when I can. | 16:01:12 |
Bryan | Depends on how you solved it. If you added torch to checkInputs, maybe add it to the default overrides in poetry2nix.
I don't think you need to worry if you ultimately just disabled the tests for clu.
I don't see a way that this would lead you to nixpkgs in either case though (you're modifying a derivation that poetry2nix creates, not one from nixpkgs).\
| 17:33:43 |
| 26 Aug 2022 |
| Luc Tielen left the room. | 22:01:32 |
| 30 Aug 2022 |
| aru joined the room. | 14:41:56 |
| aru left the room. | 14:54:00 |
| 31 Aug 2022 |
Collin Arnett | https://github.com/python-poetry/poetry/releases/tag/1.2.0 | 11:26:38 |
Collin Arnett | Boom | 11:26:41 |
adisbladis | I'm unlikely to have time to look into supporting the new pyproject.toml syntax any time soon (see that as a call to action).
Patches very welcome.
| 11:51:58 |
adisbladis | Not sure what we'll do with dependency groups yet. | 11:52:11 |
| 1 Sep 2022 |
adisbladis | Got the ball rolling: https://github.com/nix-community/poetry2nix/pull/704 | 15:34:59 |
adisbladis | Aand it seems that we're up to parity with older Poetry versions | 16:26:37 |
adisbladis | It does however depend on a nixpkgs change that has to propagate out in the channels | 16:26:57 |
adisbladis | For now I'm ignoring dependency groups other than dev | 16:27:21 |
| 2 Sep 2022 |
adisbladis | Another update on dependency groups: They are now supported in https://github.com/nix-community/poetry2nix/pull/704 and tests pass if I point nixpkgs to my local checkout based on master | 03:02:42 |
adisbladis | We're just awaiting https://github.com/NixOS/nixpkgs/pull/187999 + the backport to hit the channels and then I'll merge 1.2.0 | 03:04:09 |
| 5 Sep 2022 |
| kotatsuyaki joined the room. | 05:06:02 |
pbsds | Does poetry2nix also support the lockfiles of pdm? | 08:22:38 |