| 20 Sep 2024 |
 @rick:matrix.ciphernetics.nl | In reply to @teutat3s:pub.solar
I'd like to understand why pkgs.signal-desktop.meta.maintainers do not get pinged by OfBorg. https://github.com/NixOS/nixpkgs/pull/342687
Is there anything obvious missing for OfBorg to ping correctly? I think the PR was merged before eval finished, possibly | 06:57:37 |
 Lily Foster | In reply to @rick:matrix.ciphernetics.nl
I think the PR was merged before eval finished, possibly eval finished. splitting the signal-desktop files in such a weird way probably breaks the detection here though: https://github.com/NixOS/ofborg/blob/released/ofborg/src/maintainers.nix#L50-L77 | 13:15:16 |
 @teutat3s:pub.solar | Thank you for taking a look at it. Could we achieve code re-usage for signal-desktop in a better way without breaking ofborg detection of maintainers? | 14:42:56 |
 Artturin | In reply to @teutat3s:pub.solar
Thank you for taking a look at it. Could we achieve code re-usage for signal-desktop in a better way without breaking ofborg detection of maintainers? Maybe with pos https://github.com/search?q=repo%3ANixOS%2Fnixpkgs%20%2Fpos%20%3D%2F&type=code | 14:50:14 |
| Artturin | Maintainer requests also work for us for the discord package | 14:51:28 |
| Lily Foster | In reply to @teutat3s:pub.solar
Thank you for taking a look at it. Could we achieve code re-usage for signal-desktop in a better way without breaking ofborg detection of maintainers? keep meta in the same file as version like other packages do when they do that pattern or yeah pos it | 15:02:12 |
| @teutat3s:pub.solar | Okay, I'll give that a try, thank you all! | 15:02:48 |
| Lily Foster | you can do the unsafeGetAttrPos calls like ofborg above in repl to check what a given package attrs's maintainers "relevant files" are to ofborg | 15:04:08 |
| Lily Foster | * you can do the unsafeGetAttrPos calls like ofborg above in repl to check what a given package attrs's maintainers' "relevant files" are to ofborg | 15:04:41 |
