| 22 Feb 2023 |
Winter (she/her) | In reply to @qyliss:fairydust.space I wonder if that should be dropped? AIUI broken doesn't block accessing any attributes, so it shouldn't miss any eval breakages to disallow broken. Broken only stops you if you're evaluating every attribute AFAICT | 20:11:14 |
Alyssa Ross | hmm | 20:11:19 |
Alyssa Ross | it shouldn't do | 20:11:22 |
cole-h | Or maybe it was debugging during development that's been cargo-culted 🤷 | 20:11:23 |
Alyssa Ross | Specifically broken disallows accessing outPath or drvPath | 20:11:30 |
Alyssa Ross | As it's implemented with lib.extendDerivation | 20:12:42 |
| 23 Feb 2023 |
Winter (she/her) | has anyone ever succeeded in running a local OfBorg for testing? or is that still like impossible? 😄 | 17:41:35 |
cole-h | I mean, I have, but that's because I have access to the secrets ofborg needs... 😅 | 17:42:14 |
Winter (she/her) | In reply to @cole-h:matrix.org I mean, I have, but that's because I have access to the secrets ofborg needs... 😅 I meant like, in my own environment/Nixpkgs copy and whatnot | 17:43:16 |
Artturin | https://github.com/NixOS/ofborg/pull/562 | 17:43:35 |
cole-h | Oh neat | 17:44:16 |
Winter (she/her) | wonder how usable that is right now | 17:44:38 |
Winter (she/her) | given it's age | 17:44:46 |
Winter (she/her) | * given its age | 17:44:49 |
cole-h | Might be some slight API changes but I don't think it would be too difficult to get up and running again | 17:45:02 |
Winter (she/her) | hmm, i'll give it a try | 17:45:18 |
Artturin | i tried something here https://github.com/Artturin/ofborg/commits/oneoff (the 2 c commits) | 17:45:32 |
Artturin | i dont remember what since its been a while | 17:45:45 |
Winter (she/her) | looks like you just did the API changes | 17:45:55 |
Winter (she/her) | neat | 17:46:19 |
Winter (she/her) | will pull down your branch and take a look, thank ykun | 17:46:33 |
Winter (she/her) | * will pull down your branch and take a look, thank you | 17:46:41 |
| 27 Feb 2023 |
dotlambda | Can we make ofborg fail if aliases are used? | 16:40:49 |
dotlambda | Nixpkgs-review keeps failing on me when someone introduces an alias but forgets to update the references treewide. | 16:41:30 |
dotlambda | e.g. https://github.com/NixOS/nixpkgs/pull/218641 | 16:41:46 |
cole-h | Well, there is a ofborg-eval-package-list-no-aliases check, but that indeed doesn't catch it. I'll take a look in a few. | 16:47:40 |
| 24 Mar 2023 |
vcunat | There's another case: https://github.com/NixOS/nixpkgs/pull/222710#issuecomment-1482486968 | 09:18:44 |
vcunat | The command
nix-env -qa --json --file . --arg config '{ allowAliases = false; }'
doesn't seem suitable for this check.
| 09:23:15 |
| @raboof:matrix.org joined the room. | 09:39:31 |
Sandro | In reply to @robert:funklause.de Nixpkgs-review keeps failing on me when someone introduces an alias but forgets to update the references treewide. It only does that because there shouldn't be aliases allowed 🤡 | 09:39:48 |