| 20 Jul 2022 |
Winter (she/her) | Sorry for barging in with another question, but why would OfBorg request kalbasit's review for this PR, which only adds a new package (and doesn't touch anything they maintain)? There's no force pushes so it's not a PR that added accidentally added commits that modified their stuff or anything, so I'm not really sure why else it would be doing that. | 04:31:03 |
Artturin | In reply to @winterqt:nixos.dev Sorry for barging in with another question, but why would OfBorg request kalbasit's review for this PR, which only adds a new package (and doesn't touch anything they maintain)? There's no force pushes so it's not a PR that added accidentally added commits that modified their stuff or anything, so I'm not really sure why else it would be doing that. It uses buildGoModule which adds kalbasit to maintainers | 04:32:05 |
Winter (she/her) | In reply to @artturin:matrix.org It uses buildGoModule which adds kalbasit to maintainers oh, that makes sense; wonder why they'd decide to torture themselves with that 😅 thanks. | 04:42:24 |
Sandro | Going to remove that later. | 08:01:29 |
hexa | yeah, very much about time to remove kalbasit | 10:19:33 |
hexa | very pointless review requests | 10:19:41 |
Sandro | FYI https://github.com/NixOS/nixpkgs/pull/182228 | 16:29:52 |
| 24 Jul 2022 |
Winter (she/her) | Noticed an OfBorg internal error on https://github.com/NixOS/nixpkgs/pull/182690, failing status is because I triggered it manually. | 15:57:16 |
Winter (she/her) | Another one: https://github.com/NixOS/nixpkgs/pull/182728 | 18:06:38 |
| 25 Jul 2022 |
Winter (she/her) | And another 😕 https://github.com/NixOS/nixpkgs/pull/182745 | 04:23:53 |
Sandro | you don't need to post every here, we can just give the bot a kick in the bot. | 08:55:37 |
Sandro | * you don't need to post every here, we can just give the bot a kick in the but. | 08:55:41 |
cole-h | Yep, I do actually check them every once in a while... Usually just the GitHub API sending incomplete responses :')
I appreciate the assistance though. | 14:21:24 |
Winter (she/her) | anyone know why OfBorg would either fail to find the changed attributes, or not find the maintainers on https://github.com/NixOS/nixpkgs/pull/182884? | 22:59:08 |
| 26 Jul 2022 |
| @tinybronca:sibnsk.net changed their display name from tinybronca to tailrec. | 14:49:21 |
| @tinybronca:sibnsk.net changed their display name from tailrec to tinybronca. | 15:43:51 |
| 27 Jul 2022 |
| @ninjatrappeur:alternativebit.fr joined the room. | 17:43:21 |
Winter (she/her) | does OfBorg not eval anything with hydraPlatforms = [] or something? it didn't detect any changed attrs for this PR | 18:50:19 |
Winter (she/her) | oh maybe it doesn't eval for binaryNativeCode? | 18:55:12 |
Winter (she/her) | i think i'm making up a reason lol | 18:55:46 |
| 28 Jul 2022 |
Winter (she/her) | tangibly related, in this PR, OfBorg detected changed paths, but no maintainers (even though these packages have maintainers)
although in this case it's actually a good thing since it would be review spam for no reason since it's not directly related to any of these packages, it still seems weird that it wasn't able to identify a single maintainer...?
| 03:59:52 |
| 30 Jul 2022 |
| Sandro changed their display name from Sandro to Sandro 🐧. | 13:17:05 |
| 1 Aug 2022 |
| @better_sleeping:converser.eu joined the room. | 09:12:28 |
| @better_sleeping:converser.eu left the room. | 09:12:46 |
| 12 Aug 2022 |
Winter (she/her) | How was OfBorg able to eval this PR perfectly fine, when it... doesn't eval? The change involves NixOS options so at least that eval should've failed, no? Or am I missing something obvious...? Thanks. | 15:55:46 |
cole-h | It does eval, it doesn't build. | 16:12:52 |
Winter (she/her) | How does it eval if the function doesn't exist? | 16:14:00 |
cole-h | Because the docs are lazy now | 16:14:09 |
Winter (she/her) | Oh | 16:14:18 |
Winter (she/her) | riiight. | 16:14:31 |