| 10 Jan 2022 |
Winter (she/her) | * So an issue that I ran into was that https://github.com/NixOS/nixpkgs/pull/153038#discussion_r780785733 (go to the last resolved discussion and expand it) didn’t cause OfBorg to detect myself as a maintainer (and add the by package maintainer label). But I’m… not really sure why. I can successfully go into a REPL and see that thelounge.meta.maintainers exists.
Does anyone have any pointers on why this would be happening, or where to look in the codebase, or something? | 00:30:09 |
Winter (she/her) | Nothing immediately stands out to me :/ | 00:32:51 |
sterni | Winter (she/her): ofborg relies on the attribute names in the commit message mostly, so the PR wouldn't trigger that code because there's no thelounge: … commit, I would assume? | 11:10:29 |
| 12 Jan 2022 |
@grahamc:nixos.org | I think “thelounge:” is only for triggering builds, not @ing maintainers. This is to encourage good commit message format, but still @ing relevant people even if the author didn’t do it quite right | 14:33:27 |
Winter (she/her) | In reply to @grahamc:nixos.org I think “thelounge:” is only for triggering builds, not @ing maintainers. This is to encourage good commit message format, but still @ing relevant people even if the author didn’t do it quite right I’m confused. You said it’s not for @ing but it would @ anyways? | 14:38:37 |
Winter (she/her) | (I’ll reword my commits to use the actual attribute name, though; thanks for the clarification.) | 14:39:46 |