!sBfrWMVsLoSyFTCkNv:nixos.org

OfBorg

173 Members
Number of builds and evals in queue: <TBD>64 Servers

Load older messages


SenderMessageTime
13 Feb 2025
@lily:lily.flowersLily Foster actually probably here since it can't canonicalize a path that may not exist yet: https://github.com/NixOS/ofborg/blob/cbf0c619db7750de1e7b575ade14d0ef35a1bde3/ofborg/src/checkout.rs#L94 17:59:54
@lily:lily.flowersLily Foster * actually probably here instead since it can't canonicalize a path that may not exist yet: https://github.com/NixOS/ofborg/blob/cbf0c619db7750de1e7b575ade14d0ef35a1bde3/ofborg/src/checkout.rs#L94 18:00:02
@lily:lily.flowersLily Foster * easiest "fix" to make it not explode in the case where it's configured to use a checkout dir that has a symlink in a path segment is probably to add a .canonicalize() to https://github.com/NixOS/ofborg/blob/cbf0c619db7750de1e7b575ade14d0ef35a1bde3/ofborg/src/checkout.rs#L17 18:01:03
@lily:lily.flowersLily Foster ( Janne Heß if you wanted the fix to the macOS builders failing to evaluate anything ^) 18:03:15
14 Feb 2025
@cleverca22:matrix.orgcleverca22 joined the room.01:11:13
16 Feb 2025
@janne.hess:helsinki-systems.deJanne Heß Lily Foster: Whoa, thank you for the research <3 Looking into it right now 15:37:45
@janne.hess:helsinki-systems.deJanne HeßI don't really understand your point about the canonicalize() through. If I canonicalize the path in rust, and give it to nix, wouldn't that mean that nix still tries to access /private?15:39:16
@lily:lily.flowersLily Foster
In reply to @janne.hess:helsinki-systems.de
I don't really understand your point about the canonicalize() through. If I canonicalize the path in rust, and give it to nix, wouldn't that mean that nix still tries to access /private?
yes but the ofborg-nixpkgs-pr in NIX_PATH would then include /private so nix would allow it under restricted eval
17:39:13
@lily:lily.flowersLily Foster * yes but the ofborg-nixpkgs-pr in NIX_PATH would then include /private/... so nix would allow it under restricted eval 17:39:31
@janne.hess:helsinki-systems.deJanne HeßAhhh I see. Thanks I will try that19:07:24
@janne.hess:helsinki-systems.deJanne Heßimage.png
Download image.png
19:32:18
@janne.hess:helsinki-systems.deJanne HeßCurrently deploying with my patented "tmux + ssh" system19:32:34
@janne.hess:helsinki-systems.deJanne HeßDeployment done on all macs19:39:28
@janne.hess:helsinki-systems.deJanne Heß Looking good now, thank you Lily Foster 😍 19:53:35
@janne.hess:helsinki-systems.deJanne Heßhttps://logs.ofborg.org/?attempt_id=229e3574-efaf-44e0-b436-ba0fe5795c61&key=nixos%2Fnixpkgs.38264119:53:39
19 Feb 2025
@hexa:lossy.networkhexahttps://github.com/NixOS/infra/blob/main/macs/mac-update15:31:50
@hexa:lossy.networkhexa* https://github.com/NixOS/infra/blob/main/macs/mac-update https://github.com/NixOS/infra/blob/main/macs/mac-exec15:31:57
@hexa:lossy.networkhexathe unpatented nixos/infra macos tooling15:32:18
@hexa:lossy.networkhexa
error: a 'x86_64-linux' with features {} is required to build '/nix/store/vnlk0g6i2a2pk6xnlbiai03vxvz6s179-append-initrd-secrets.drv', but I am a 'x86_64-darwin' with features {apple-virt, benchmark, big-parallel, nixos-test}
15:33:17
@hexa:lossy.networkhexa trying to build esphome.tests 15:33:35
@hexa:lossy.networkhexahttps://logs.ofborg.org/?key=nixos/nixpkgs.383404&attempt_id=b4cf0697-ebfc-4a42-9e4a-a02e5c5d6ef415:33:44
@hexa:lossy.networkhexa frankly, that is to be expected when calling nix-build --eval-system aarch64-darwin -A esphome.tests, but at the same time that means that it doesn't build the attribute esphome itself 15:35:43
@hexa:lossy.networkhexa
$ nix-build --eval-system aarch64-darwin -A esphome -A esphome.tests --eval-system aarch64-darwin --keep-going --always-allow-substitutes
[...]
error: a 'aarch64-linux' with features {} is required to build '/nix/store/fcbvsy7z7y8p42ps667glhz6rn8kdi99-linux-6.12.15.tar.xz.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}
15:39:00
@hexa:lossy.networkhexa🤨15:39:19
@janne.hess:helsinki-systems.deJanne HeßUmmm17:51:10
@janne.hess:helsinki-systems.deJanne Heß That's all due to the evaluator being removed and ofborg not really being able to tell what attrs actually exist :( 17:52:49
@lily:lily.flowersLily Foster wait why is it not failing the meta.platforms check and throwing an eval error (which should be ignored iirc) instead of trying to build for the wrong platform 18:01:27
@lily:lily.flowersLily Fosterare nixos tests fucky on darwin by rewriting the system from -darwin to -linux when evaluating for a -darwin nixpkgs...?18:03:11
@lily:lily.flowersLily Foster(regardless, you should probably be building the attr list individually for this kind of reason or otherwise be using something that can handle eval errors or inability to build)18:04:11
@lily:lily.flowersLily Foster yeah they expect you to have the "remote" builder VM set up to run nixos tests on darwin (i remember this change now -- ofborg has had problems with it since it was introduced) https://github.com/NixOS/nixpkgs/pull/282401 18:15:54

Show newer messages


Back to Room ListRoom Version: 6