In reply to @hexa:lossy.network
though that only works if you have commit access

In reply to @winterqt:nixos.dev
yeah, since I don’t I figured that would be the next best thing

In reply to @winterqt:nixos.dev
tbh i might dedicate time to implementing it, if i can get a grasp for ofborg’s codebase

In reply to @piegames:matrix.org
A Codeowners reimplementation without stupid limitations. Let me grab you the issue(s)

In reply to @winterqt:nixos.dev
yeah this is not bad at all, other than the fact that a local instance apparently can’t be setup easily
i’ll take a shot at it :)

In reply to @winterqt:nixos.dev
Should changes be based off of release?

Hey grahamc (he/him) -- I'm looking at ImpactedMaintainers::calculate, and I notice this expression:

        let mut cmd = nix.safely_evaluate_expr_cmd(
            checkout,
            include_str!("./maintainers.nix"),
            argstrs,
            &[path_file.path(), attr_file.path()],
        );

Why do you add the 2 tempfiles (path_file, attr_file) to safe_paths, which seemingly just adds them to NIX_PATH? Do they need to be there for whatever reason? I ask since maintainers.nix just imports them by absolute path, not <...>.

In reply to @winterqt:nixos.dev
Is the sandbox enabled on the Darwin builders?