!sBfrWMVsLoSyFTCkNv:nixos.org

OfBorg

171 Members
Number of builds and evals in queue: <TBD>61 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
16 Sep 2024
@silentlurker:matrix.orgsilentlurker joined the room.20:00:43
17 Sep 2024
@cafkafk:gitter.imcafkafkis there a way to make more targeted donations for stuff like this other than just like nixos foundation?13:31:49
@dandellion:dodsorf.asDandellion joined the room.15:11:47
18 Sep 2024
@teutat3s:pub.solar@teutat3s:pub.solar joined the room.14:21:36
@teutat3s:pub.solar@teutat3s:pub.solar I'd like to understand why pkgs.signal-desktop.meta.maintainers do not get pinged by OfBorg. https://github.com/NixOS/nixpkgs/pull/342687
Is there anything obvious missing for OfBorg to ping correctly?
14:23:45
@artur:glasgow.socialmoved to @amadaluzia:tchncs.de changed their profile picture.23:01:04
20 Sep 2024
@rick:matrix.ciphernetics.nl@rick:matrix.ciphernetics.nl
In reply to @teutat3s:pub.solar
I'd like to understand why pkgs.signal-desktop.meta.maintainers do not get pinged by OfBorg. https://github.com/NixOS/nixpkgs/pull/342687
Is there anything obvious missing for OfBorg to ping correctly?
I think the PR was merged before eval finished, possibly
06:57:37
@lily:lily.flowersLily Foster
In reply to @rick:matrix.ciphernetics.nl
I think the PR was merged before eval finished, possibly
eval finished. splitting the signal-desktop files in such a weird way probably breaks the detection here though: https://github.com/NixOS/ofborg/blob/released/ofborg/src/maintainers.nix#L50-L77
13:15:16
@teutat3s:pub.solar@teutat3s:pub.solarThank you for taking a look at it. Could we achieve code re-usage for signal-desktop in a better way without breaking ofborg detection of maintainers?14:42:56
@artturin:matrix.orgArtturin
In reply to @teutat3s:pub.solar
Thank you for taking a look at it. Could we achieve code re-usage for signal-desktop in a better way without breaking ofborg detection of maintainers?
Maybe with pos https://github.com/search?q=repo%3ANixOS%2Fnixpkgs%20%2Fpos%20%3D%2F&type=code
14:50:14
@artturin:matrix.orgArtturinMaintainer requests also work for us for the discord package14:51:28
@lily:lily.flowersLily Foster
In reply to @teutat3s:pub.solar
Thank you for taking a look at it. Could we achieve code re-usage for signal-desktop in a better way without breaking ofborg detection of maintainers?
keep meta in the same file as version like other packages do when they do that pattern or yeah pos it
15:02:12

Show newer messages


Back to Room ListRoom Version: 6