| 23 Feb 2023 |
Winter (she/her) | * will pull down your branch and take a look, thank you | 17:46:41 |
| 27 Feb 2023 |
dotlambda | Can we make ofborg fail if aliases are used? | 16:40:49 |
dotlambda | Nixpkgs-review keeps failing on me when someone introduces an alias but forgets to update the references treewide. | 16:41:30 |
dotlambda | e.g. https://github.com/NixOS/nixpkgs/pull/218641 | 16:41:46 |
cole-h | Well, there is a ofborg-eval-package-list-no-aliases check, but that indeed doesn't catch it. I'll take a look in a few. | 16:47:40 |
| 24 Mar 2023 |
vcunat | There's another case: https://github.com/NixOS/nixpkgs/pull/222710#issuecomment-1482486968 | 09:18:44 |
vcunat | The command
nix-env -qa --json --file . --arg config '{ allowAliases = false; }'
doesn't seem suitable for this check.
| 09:23:15 |
| @raboof:matrix.org joined the room. | 09:39:31 |
Sandro | In reply to @robert:funklause.de Nixpkgs-review keeps failing on me when someone introduces an alias but forgets to update the references treewide. It only does that because there shouldn't be aliases allowed 🤡 | 09:39:48 |
hexa | in https://github.com/NixOS/nixpkgs/pull/219493 tests on aarch64-linux are shown as successful, but following the link the log is 404 | 12:39:38 |
hexa | which is funny, since apparently the build doesn't even succeed | 12:41:09 |
hexa | the tests for aarch64-linux were handleTestOn [ "x86_64-linux" ] only | 13:26:28 |
hexa | 🥁 | 13:26:31 |
cole-h | In reply to @hexa:lossy.network which is funny, since apparently the build doesn't even succeed Sigh I should really fix that. Iirc it happens when the logs are completely empty... | 13:45:08 |
hexa | nix also returned early | 13:47:42 |
hexa | Thats why there is no log | 13:47:54 |
cole-h | In reply to @vcunat:matrix.org
The command
nix-env -qa --json --file . --arg config '{ allowAliases = false; }'
doesn't seem suitable for this check.
Do you happen to know a better invocation for this purpose? I should also fix this 😅 | 13:50:42 |