| 7 Dec 2022 |
 sterni | 2.4-2.12 is like one major release, I don't feel like 2.3 is far enough away yet | 15:39:25 |
 Artturin | 1 year 1 month btw | 15:40:17 |
 Alyssa Ross | Yeah, that feels way less old than previous minimums? | 16:39:03 |
 hexa | the nix_2_3 removal isn't dropping the minversion | 16:41:17 |
| hexa | the nix versions cleanup is | 16:41:26 |
| hexa | * the nix_2_3 removal isn't increasing the minversion | 16:41:44 |
| 8 Dec 2022 |
 Vladimír Čunát | I see that OfBorg doesn't detect usage of URL literals, but it's an easy to make mistake that blocks channels (forbidden for long, since nixpkgs 16f44b24f). | 07:03:43 |
| Vladimír Čunát | It should be fairly easy to execute commands with
--option experimental-features 'no-url-literals'
Maybe I'll try a PR later, though I'm not familiar with the code base yet.
| 07:06:37 |
| Artturin | Adding it here may work | 07:15:08 |
| Artturin | Try with outpaths.nix | 07:16:00 |
| Artturin | https://github.com/NixOS/ofborg/blob/6daa9f8f941b13eeb6bd9424f7a29b0d540b55a3/ofborg/src/nixenv.rs#L102 | 07:22:12 |
| Artturin | nix-env -qa --out-path --no-name -f outpaths.nix --arg checkMeta false --verbose--option extra-experimental-features 'no-url-literals'
| 07:36:46 |
| Artturin | evaluating file '/home/artturin/nixpkgs/.worktree/1/pkgs/games/tennix/default.nix'
error: URL literals are disabled
at /home/artturin/nixpkgs/.worktree/1/pkgs/games/tennix/default.nix:8:11:
7| src = fetchgit {
8| url = git://repo.or.cz/tennix.git;
| ^
9| rev = "refs/tags/tennix-${version}";
| 07:36:50 |
| Artturin | https://github.com/NixOS/ofborg/pull/628 | 07:53:19 |
| Artturin | cargo test is failing though | 07:53:27 |
| Artturin | error: unrecognised flag '--option experimental-features 'no-url-literals''
Try 'nix-build --help' for more information.
| 07:53:50 |
| Artturin | no idea why | 07:55:46 |
| Artturin | i already checked by adding --version to Operation::Build and it was 2.11 | 07:56:15 |
| Vladimír Čunát | Bad quoting. | 07:56:58 |
| Vladimír Čunát | At least that's what the error message looks like. | 07:57:06 |
| Vladimír Čunát | On command level, three arguments should be added. --option experimental-features no-url-literals | 07:59:15 |
| Artturin | thanks that was it | 08:00:53 |
| Artturin | now tests pass | 08:01:44 |
| Vladimír Čunát | By any chance, you're not getting this?
warning: unknown experimental feature ''no-url-literals''
| 08:03:44 |
| Artturin | in cargo test? | 08:04:23 |
| Vladimír Čunát | I'm not sure, but I think the apostrophes are extraneous, but maybe some layer in OfBorg would remove them. | 08:05:19 |
| Vladimír Čunát | * I think the apostrophes are extraneous, but I'm not sure - maybe some layer in OfBorg would remove them. | 08:05:31 |
| Vladimír Čunát | The error above is what I get by simply running the command in a way that shell doesn't remove the apostrophes. | 08:07:18 |
| Artturin | they're single quotes btw | 08:07:37 |
| Artturin | ah wait | 08:07:52 |
