| 6 Jun 2022 |
 @grahamc:nixos.org | cole-h: this'd let us netboot the ofborg builders: https://github.com/DeterminateSystems/nix-netboot-serve/pull/12 | 01:57:04 |
| @grahamc:nixos.org | using approles' pull authentication: https://learn.hashicorp.com/tutorials/vault/approle?in=vault/auth-methods | 01:58:15 |
| @grahamc:nixos.org | (Though there are some minor flaws) | 02:22:59 |
 7c6f434c | https://github.com/NixOS/nixpkgs/pull/176498 @cole-h fresh «CI fine, no auto review request» | 06:44:38 |
| 7c6f434c | * https://github.com/NixOS/nixpkgs/pull/176498 fresh «CI fine, no auto review request» | 06:44:39 |
| 7c6f434c | cole-h: failed to ping you from the first try… | 06:44:39 |
 cole-h | Thanks for the ping. Nothing out of the ordinary in the logs, so I'll need to PR something to augment the logging there and see if I can't catch why it's happening. | 17:36:56 |
| 7c6f434c | https://github.com/NixOS/nixpkgs/pull/176563/checks?check_run_id=6758559111 Erm. Is gcc supposed to be able to say that? | 19:36:37 |
| 7 Jun 2022 |
 hexa | https://github.com/NixOS/nixpkgs/pull/176646 touches mailcap and buildcatrust | 01:31:32 |
| hexa | https://gist.github.com/GrahamcOfBorg/f1f14001951cb28d01e570084f25e237 | 01:31:43 |
| hexa | Maintainers:
magenbluten: rocksdb_6_23, rocksdb_6_23, rocksdb_6_23, rocksdb_6_23
mweinelt: ansible, ansible_2_12, ansible, ansible_2_12, ansible_2_12, ansible_2_12, ansible, ansible
globin: promtail, promtail, promtail, promtail
kalbasit: promtail, promtail, promtail, promtail
c0bw3b: mailcap, mailcap, mailcap, mailcap
mmahut: promtail, promtail, promtail, promtail
supersandro2000: libgit2_1_3_0, libgit2_1_3_0, libgit2_1_3_0, libgit2_1_3_0
adevress: rocksdb_6_23, rocksdb_6_23, rocksdb_6_23, rocksdb_6_23
willibutz: promtail, promtail, promtail, promtail
| 01:31:56 |
| hexa | and then
@ofborg ofborg bot requested review from mweinelt and SuperSandro2000 6 minutes ago
| 01:32:18 |
 Sandro 🐧 | Is our aliases code seriously broken or the ofborg check?
https://github.com/NixOS/nixpkgs/pull/176723 | 14:58:54 |
| cole-h | Could you say more...? | 15:08:00 |
| Sandro 🐧 | The ofborg check which checks for aliases is green but we are clearly using aliases in the tree. I know that this happens for unfree packages which already got tried to fix multiple times but there are also free packages in there and modules. | 15:12:46 |
| Sandro 🐧 | Maybe this is also dead code but I would expect ofborg to catch such cases. Maybe we need to evaluate the entire documentation? | 15:13:27 |
 Alyssa Ross | sandro: I don't think that's an OfBorg problem, really — the code in NixOS modules is largely conditional on module options, so to be guaranteed to catch aliasing violations you'd have to evaluate every possible combination of NixOS options | 15:29:22 |
| Alyssa Ross | in fact, as soon as stuff like with is involved, I'd assume it would be undecidable | 15:30:03 |
| Sandro 🐧 | hmmm... you're probably right. Would be cool if we could find a way around this | 15:31:01 |
| Alyssa Ross | I think what we're looking for is coverage checking | 15:31:39 |
| Alyssa Ross | but I think that would have to be integrated into Nix | 15:31:53 |
| Alyssa Ross | then you could see that these lines aren't evaluated by OfBorg, and try to add something that would evaluate them | 15:32:13 |
| Sandro 🐧 | that would be really useful | 15:32:29 |
| 7c6f434c | Rest assured it is undecidable even without with whether a line of code is dead or not… Coverage tracker sounds useful, yes. I wonder what fraction of the dead code would come from optional feature flags never set in Nixpkgs, of course. | 19:48:49 |
 dotlambda | ofborg also didn't flag the usage of an alias in https://github.com/NixOS/nixpkgs/pull/176734 | 21:29:02 |
| 9 Jun 2022 |
| dotlambda | ofborg didn't flag the usage of an alias in https://github.com/NixOS/nixpkgs/pull/175637 but nixpkgs-review does detect it | 00:13:06 |
| Sandro 🐧 | *I think nixpkgs-review only uses it for one eval and it is a bit buggy | 07:37:21 |
| Sandro 🐧 | Best to turn aliases of in config. Nix | 07:37:21 |
| 21 Jun 2022 |
 ncfavier | running @ofborg test networking wireguard gives instant success with a weird 404 log, while @ofborg build nixosTests.networking nixosTests.wireguard is fine | 21:13:21 |
| ncfavier | @ofborg test networking.networkd.dhcpSimple is fine so it's probably a problem with attrsets | 21:15:13 |
