| 23 May 2021 |
 Alyssa Ross | oh, think I deleted it though | 16:06:54 |
 Sandro 🐧 | do you have a ref? maybe github didn't delete it yet | 16:31:23 |
| Alyssa Ross | don't think I pushed it | 16:32:11 |
| Alyssa Ross | pretty sure it's gone -- I did have a look | 16:32:18 |
 cole-h | Probably wasn't pushed :P | 16:32:19 |
| Alyssa Ross | I don't think it was all that much work anyway so no great loss | 16:32:28 |
| Alyssa Ross | like, I managed to work it out having never touched OfBorg before | 16:32:47 |
| Alyssa Ross | so it couldn't have been very hard | 16:32:58 |
| cole-h | Maybe you're just that smart ;) | 16:34:00 |
| Alyssa Ross | I don't think so :) | 16:34:16 |
| cole-h | (I do) | 16:34:28 |
| cole-h | But regardless! It is something I want to tackle. | 16:34:43 |
| cole-h | ...eventually. The week ahead of me is very, very busy, so probably gonna take some time to get to it... | 16:35:11 |
|  philipp joined the room. | 21:04:21 |
| 24 May 2021 |
 andi- | grahamc (he/him) / cole-h : any opinions about adding codeowners functionality to ofBorg? The rational is that codeowners currently don't work for groups and maintainers as those need write access to be pinged on changes to specific parts of the repository. | 11:00:57 |
 @grahamc:nixos.org | sgtm | 11:04:40 |
| andi- | Alright, I'll invest a bit more time on this then. | 11:05:21 |
| andi- | The GitHub documentation states that they implement codeowners much like gitignore but then they have contradicting examples in their documentation... Our CODEOWNERS file is actually like a gitignore file so I assume their docs are wrong... | 14:38:11 |
| Sandro 🐧 | Does that mean it supports ! for negating filters? | 15:29:12 |
| andi- | I haven't tried if it does that I have just seen that it contradicts with the realworld usage.. | 15:30:05 |
| andi- | e.g. gitignore specifies foo/bar/ will match /foo/bar but not /a/foo/bar but that is what they say in their docs :D | 15:30:34 |
| andi- | Given that they list ! as one of the explicit exceptions I don't think it will work.. | 15:32:54 |
| andi- | The differences are more around the slashes and at which positions they are allwoed | 15:33:13 |
| Sandro 🐧 | sounds strange lol | 15:34:09 |
| andi- | One of the examples in the gitignore manpage:
• If there is a separator at the end of the pattern then the pattern will only match
directories, otherwise the pattern can match both files and directories.
Compare that to this example from the GitHub docs:
# In this example, @octocat owns any file in an apps directory
# anywhere in your repository.
apps/ @octocat
| 15:38:14 |
| andi- | Perhaps it is a matter of wording... As ignoring the whole subtree == owning all the files? | 15:39:15 |
|  Stéphan joined the room. | 18:23:37 |
|  [0x4A6F] joined the room. | 18:48:02 |
 7c6f434c | I have a feeling that /bin/sh in Nix sandbox works on OfBorg in general, but not always on aarch64-linux https://github.com/NixOS/nixpkgs/pull/124289/checks?check_run_id=2658877113 — is it a bug or a feature? | 19:46:47 |
| 25 May 2021 |
| 7c6f434c | (rerunning ofborg build did not change the result) | 07:20:46 |
