| 30 Dec 2021 |
 cole-h | It looks like the issue I was trying to fix has indeed been fixed (at least, no more occurrences in the past ~10 hours), so, all PRs should be getting picked up again.... | 19:40:02 |
| 9 Jan 2022 |
|  Winter (she/her) joined the room. | 00:59:15 |
| Winter (she/her) | If a module has no maintainers set, does OfBorg pick a reviewer at random? | 00:59:37 |
 hexa | https://github.com/NixOS/ofborg/issues/568 | 01:02:45 |
| hexa | https://github.com/NixOS/nixpkgs/pull/128447 | 01:02:53 |
 piegames | Module maintainers are not pinged at all, regardless of maintainers (: | 01:03:05 |
| Winter (she/her) | Noted — what are they used for, then? | 01:13:40 |
| piegames | Ideally, for pinging the reponsible people. At the moment, nothing I would know of. If you edit a module you'll know whom to ping, I guess | 01:19:48 |
| hexa | In reply to @winterqt:nixos.dev
Noted — what are they used for, then? wishful thinking | 01:20:03 |
| hexa | expectation of a glorious future | 01:20:09 |
| Winter (she/her) | heh | 01:21:15 |
| Winter (she/her) | so it’s still a good idea to keep them up to date? | 01:21:27 |
| hexa | if you want to get pinged use the CODEOWNERS feature instead | 01:21:40 |
| hexa | though that only works if you have commit access | 01:21:45 |
| piegames | In reply to @winterqt:nixos.dev
so it’s still a good idea to keep them up to date? Yes | 01:21:48 |
| Winter (she/her) | In reply to @hexa:lossy.network
though that only works if you have commit access yeah, since I don’t I figured that would be the next best thing | 01:22:08 |
| Winter (she/her) | is there any reason we currently don’t take them into account for automated pinging/assigning other than we just don’t atm? | 01:22:36 |
| hexa | there is an example of how to collect meta.maintainers from modules in that ofborg issue | 01:23:02 |
| hexa | someone needs to implement the feature | 01:23:10 |
| hexa | IMO the foundation should support ofBorg with money | 01:23:26 |
| Winter (she/her) | tbh i might dedicate time to implementing it, if i can get a grasp for ofborg’s codebase | 01:24:02 |
| piegames | In reply to @winterqt:nixos.dev
yeah, since I don’t I figured that would be the next best thing You might be interested in https://github.com/piegamesde/codeowners-rs as a workaround | 01:24:13 |
| Winter (she/her) | what is it? | 01:24:45 |
| piegames | A Codeowners reimplementation without stupid limitations. Let me grab you the issue(s) | 01:25:57 |
| Winter (she/her) | In reply to @winterqt:nixos.dev
tbh i might dedicate time to implementing it, if i can get a grasp for ofborg’s codebase yeah this is not bad at all, other than the fact that a local instance apparently can’t be setup easily
i’ll take a shot at it :) | 01:28:10 |
| piegames | In reply to @piegames:matrix.org
A Codeowners reimplementation without stupid limitations. Let me grab you the issue(s) https://github.com/NixOS/nixpkgs/issues/143441 | 01:28:24 |
| piegames | In reply to @winterqt:nixos.dev
yeah this is not bad at all, other than the fact that a local instance apparently can’t be setup easily
i’ll take a shot at it :) IIRC andi- hacked something together that allows you to do this. But otherwise, it's really a "if it compiles, then deploy and pray" | 01:29:45 |
| Winter (she/her) | that’s wonderful lmao | 01:30:06 |
| Winter (she/her) | Should changes be based off of release? | 02:16:50 |
| hexa | best to check existing PRs | 02:36:00 |
