| 9 Jan 2022 |
 Winter (she/her) | yeah, I did and figured it was okay -- just wanted to double check thoug | 02:46:50 |
| Winter (she/her) | * yeah, I did and figured it was okay -- just wanted to double check though | 02:46:52 |
 cole-h | In reply to @winterqt:nixos.dev
Should changes be based off of release? Yes indeed :) | 05:23:31 |
| Winter (she/her) | Oh god I just noticed I forgot to squash #589, whoops. Will do that in the morning. | 05:25:02 |
| Winter (she/her) | Also i believe technically its title/commit message is wrong, since both building and rust-analyzer were broken until I applied the changes, so I don’t think it’s really Darwin specific | 05:28:44 |
| Winter (she/her) | * Also I believe technically its title/commit message is wrong, since both building and rust-analyzer were broken until I applied the changes, so I don’t think it’s really Darwin specific
Should I even bother changing it? Probably will just because I have to rebase anyways but 🤷♀️ | 05:35:41 |
| Winter (she/her) | Is sandbox enabled on the Darwin builders? | 22:34:46 |
| Winter (she/her) | * Is the sandbox enabled on the Darwin builders? | 22:34:49 |
| Winter (she/her) | Hey grahamc (he/him) -- I'm looking at ImpactedMaintainers::calculate, and I notice this expression:
let mut cmd = nix.safely_evaluate_expr_cmd(
checkout,
include_str!("./maintainers.nix"),
argstrs,
&[path_file.path(), attr_file.path()],
);
Why do you add the 2 tempfiles (path_file, attr_file) to safe_paths, which seemingly just adds them to NIX_PATH? Do they need to be there for whatever reason? I ask since maintainers.nix just imports them by absolute path, not <...>.
| 22:56:00 |
| Winter (she/her) | Thanks! | 22:56:10 |
| Winter (she/her) | Oh, never mind. | 22:57:04 |
| Winter (she/her) | * Oh, nevermind. | 22:57:07 |
| Winter (she/her) | I should've dug a bit more deeper -- restrict-eval only allows paths in NIX_PATH to be accessed. | 22:57:20 |
| Winter (she/her) | That makes sense, sorry for the ping. | 22:57:25 |
 hexa | In reply to @winterqt:nixos.dev
Is the sandbox enabled on the Darwin builders? I don't believe there is a working sandbox on darwin | 23:50:14 |
| 10 Jan 2022 |
| Winter (she/her) | In reply to @hexa:lossy.network
I don't believe there is a working sandbox on darwin There definitely is (I have it enabled) | 00:10:18 |
| Winter (she/her) | But it’s not without its breakages | 00:10:25 |
| Winter (she/her) | Is there any way that I can run OfBorg locally just to debug a specific task? (calculating changed attributes)
Or should I just do the things it does to do that manually, idk.
The latter is probably simpler | 00:12:29 |
| Winter (she/her) | (I know I asked a similar question earlier so I don’t know why I’m asking again, sorry.$ | 00:13:08 |
| Winter (she/her) | * (I know I asked a similar question earlier so I don’t know why I’m asking again, sorry.) | 00:13:12 |
 piegames | In reply to @winterqt:nixos.dev
Is there any way that I can run OfBorg locally just to debug a specific task? (calculating changed attributes)
Or should I just do the things it does to do that manually, idk.
The latter is probably simpler Ah, I found it https://github.com/NixOS/ofborg/pull/562 (FWIW) | 00:16:46 |
| Winter (she/her) | I’ll take a look, thanks. | 00:26:56 |
| Winter (she/her) | So an issue that I ran into was that https://github.com/NixOS/nixpkgs/pull/153038#discussion_r780785733 (go to the last resolved discussion and expand it) didn’t cause OfBorg to detect myself as a maintainer. But I’m… not really sure why. I can successfully go into a REPL and see that thelounge.meta.maintainers exists.
Does anyone have any pointers on why this would be happening, or where to look in the codebase, or something? | 00:29:16 |
| Winter (she/her) | * So an issue that I ran into was that https://github.com/NixOS/nixpkgs/pull/153038#discussion_r780785733 (go to the last resolved discussion and expand it) didn’t cause OfBorg to detect myself as a maintainer (and add the by package maintainer label). But I’m… not really sure why. I can successfully go into a REPL and see that thelounge.meta.maintainers exists.
Does anyone have any pointers on why this would be happening, or where to look in the codebase, or something? | 00:30:09 |
| Winter (she/her) | Nothing immediately stands out to me :/ | 00:32:51 |
 sterni | Winter (she/her): ofborg relies on the attribute names in the commit message mostly, so the PR wouldn't trigger that code because there's no thelounge: … commit, I would assume? | 11:10:29 |
| 12 Jan 2022 |
 @grahamc:nixos.org | I think “thelounge:” is only for triggering builds, not @ing maintainers. This is to encourage good commit message format, but still @ing relevant people even if the author didn’t do it quite right | 14:33:27 |
| Winter (she/her) | In reply to @grahamc:nixos.org
I think “thelounge:” is only for triggering builds, not @ing maintainers. This is to encourage good commit message format, but still @ing relevant people even if the author didn’t do it quite right I’m confused. You said it’s not for @ing but it would @ anyways? | 14:38:37 |
| Winter (she/her) | (I’ll reword my commits to use the actual attribute name, though; thanks for the clarification.) | 14:39:46 |
| Winter (she/her) | * In reply to @grahamc:nixos.org
I think “thelounge:” is only for triggering builds, not @ing maintainers. This is to encourage good commit message format, but still @ing relevant people even if the author didn’t do it quite right I’m confused. You said it’s not for @ing but that it would @ anyways? | 14:44:14 |
