| 12 Jan 2022 |
@grahamc:nixos.org | There is a rule that determines what things to build, and that rule is based on attribute as named in the commit message with the prefix. It has nothing to do with @ing people, iirc. | 14:45:44 |
Winter (she/her) | Ah, understood. | 14:46:50 |
sterni | yeah seems like that should use the changed attribute paths | 14:58:34 |
| nf joined the room. | 16:08:55 |
| 13 Jan 2022 |
| NixOS Moderation Bot unbanned David Arnold (blaggacao). | 18:43:45 |
| 14 Jan 2022 |
| Chinchilla Wetreat changed their display name from Rev. CornWallace III (novus ordo seclorum) to coilWinder. | 04:39:47 |
| Chinchilla Wetreat changed their display name from coilWinder to CoilWinder (novus ordo seclorum). | 04:42:11 |
| 17 Jan 2022 |
pennae | does ofborg not parse commands from review comments? https://github.com/NixOS/nixpkgs/pull/153346#pullrequestreview-854622718 apparently hasn't started a test run | 16:44:25 |
7c6f434c | I would expect that review comments is a completely different kind of thing that Github peruidically breaks in a different way than comments (so probably ofBorg does not receive these events) | 16:46:14 |
pennae | annoying, but not entirely surprising | 16:47:51 |
Winter (she/her) | Do NixOS tests always have to be triggered manually? | 17:39:16 |
Winter (she/her) | I’ve never seen them run automatically for changed modules/tests. | 17:39:35 |
hexa | they run automatically if a package updated includes passthru.tests = [ inherit (nixosTest) foobar ]; | 18:00:47 |
hexa | * they run automatically if a package updated includes passthru.tests = { inherit (nixosTest) foobar }; | 18:00:56 |
7c6f434c | Package specified in the commit message, I think | 18:04:09 |
Winter (she/her) | Ah, got it. So changes to the module itself won’t trigger it automatically. | 18:07:28 |
hexa | these parts need more love | 18:45:23 |
| 18 Jan 2022 |
pennae | wanted to check ofborg monitoring to see why a pr is waiting for eval, noticed that https://monitoring.nix.ci/dashboard/db/ofborg seems to not exist | 15:16:42 |
Winter (she/her) | In reply to @hexa:lossy.network they run automatically if a package updated includes passthru.tests = { inherit (nixosTest) foobar }; this doesn’t seem to be true either :/
unless by updated you mean version bump and not just rebuild? | 15:59:31 |
hexa | i meant that if the package definition changes in any way, and it has a nixosTest in passthru, then ofBorg should build it | 16:00:23 |
Winter (she/her) | yeah i can’t get that to happen sadly :/ | 16:04:53 |
cole-h | In reply to @pennae:matrix.eno.space wanted to check ofborg monitoring to see why a pr is waiting for eval, noticed that https://monitoring.nix.ci/dashboard/db/ofborg seems to not exist Grafana broke last year some time when a power outage killed the machine it was running on. I haven't had time to try to piece the dashboard back together from scratch, so you'll want to look at Prometheus (https://nix.ci/prometheus) | 16:16:43 |
cole-h | Relevant metrics begin with ofborg_ | 16:17:01 |
pennae | erf, destructive crashes 😶 maybe some day | 16:18:48 |
cole-h | In reply to @pennae:matrix.eno.space erf, destructive crashes 😶 maybe some day When I do get back to it, I'll be looking into managing the dashboard declaratively (at least, once they're relatively static), so it hopefully shouldn't be a problem again....... (but that might not be for a while) | 18:21:33 |
pennae | ah, prometheus is fine for everything we're interested in :D | 18:26:55 |
Winter (she/her) | In reply to @cole-h:matrix.org When I do get back to it, I'll be looking into managing the dashboard declaratively (at least, once they're relatively static), so it hopefully shouldn't be a problem again....... (but that might not be for a while) Fair warning: it’s annoying last I checked (a few weeks ago) | 20:01:56 |
cole-h | Yeah, but it'll be worth it to not have to deal with this ever again :P | 20:02:20 |
cole-h | even if it just results in the .json committed somewhere | 20:02:33 |
Winter (she/her) | Yeah lol | 20:03:39 |