OfBorg | 175 Members | |
| Number of builds and evals in queue: <TBD> | 62 Servers |
| Sender | Message | Time |
|---|---|---|
| 26 Jun 2023 | ||
| * Some pages are barely loading for me | 08:52:10 | |
| 28 Jun 2023 | ||
In https://github.com/NixOS/nixpkgs/pull/239881 running @ofborg eval was enough to get rid of ofborg-internal-error. Is it intentional that internal error label does not get removed automatically? | 07:02:31 | |
* In https://github.com/NixOS/nixpkgs/pull/239881 running @ofborg eval was enough to get rid of ofborg-internal-error condition (but not label). Is it intentional that internal error label does not get removed automatically? | 07:02:47 | |
In reply to @trofi:matrix.orgYes, so a ofborg maintainer can check it | 07:04:54 | |
| (Which, to be fair, I've been bad about recently... but also to be fair, usually it's GH's API and not ofborg) | 13:33:00 | |
| tbh I've just been removing the label, should I keep the label and not remove it? | 13:37:28 | |
It doesn't affect anything (other than telling you you'll want to @ofborg eval again), so if you wouldn't mind, please leave it :) | 13:38:01 | |
| While I don't do it often, I do check the logs every once in a while to make sure they didn't change the API out from under us (hasn't happened yet, but) | 13:38:27 | |
| 7 Jul 2023 | ||
| A quick question, in case you know easily: do we control what version+features of Nix are used in the evals? | 16:20:07 | |
| I think so? | 16:20:32 | |
| goes to check | 16:20:42 | |
I expect we want to use 2.3.x with just default features? (nixpkgs/lib/minver.nix) | 16:21:13 | |
| It's nothing urgent. It just came up in NixOS release-managing discussion. | 16:23:03 | |
| Maybe... | 16:23:10 | |
| Is there a case that would have been caught with 2.3 that wasn't? | 16:23:56 | |
| I'm not aware of any, but I expect it won't be hard to create some artificial one. | 16:24:41 | |
| remember that 2.3 may have worse performance than 2.4+ | 17:08:41 | |
| likely has | 17:08:53 | |
Which is especially important when evals take 10 minutes on recent masters... | 17:09:08 | |
| So I'd be hesitant to even entertain the idea of pinning to 2.3 until I see an actual, non-contrived / non-forced issue caused by not using the Nixpkgs minver | 17:09:59 | |
| We should probably measure the difference in performance on the particular expensive eval ofBorg is doing. Otherwise I don't trust it really. | 17:12:05 | |
| I'll do so. On
| 17:13:06 | |
Running 2.4pre20210810_a6ba313 (not an ofborg machine, but same type) | 17:14:08 | |
| (I already bisected the largest increase in eval time to 4af22aab8e239b1ca28da851755c6da1a35fc91b, which made the leap from ~4-5m to like 7m, but not yet the remaining increase to 10m) | 17:17:20 | |
* (I already bisected the largest increase in eval time to 4af22aab8e239b1ca28da851755c6da1a35fc91b, which made the leap from ~4-5m to like 7m, but not yet the remaining increase to 10m) | 17:17:28 | |
| 2.3.16 and 2.4pre-rc1 have a difference of 3,902 commits https://github.com/NixOS/nix/compare/2.3.16...2.4pre-rc1 | 17:24:14 | |
| * fun fact 2.3.16 and 2.4pre-rc1 have a difference of 3,902 commits https://github.com/NixOS/nix/compare/2.3.16...2.4pre-rc1 | 17:26:46 | |
13:40 on the same commit using Nix 2.13 | 17:31:47 | |
*
13m40s on the same commit using Nix 2.13 | 17:31:51 | |
| Err Nix 2.3 | 17:33:15 | |