| 10 Apr 2023 |
 K900 | That's not really true either though | 13:33:40 |
| K900 | There are also valid situations where you might want to merge something that's still broken but maybe becomes less broken | 13:34:02 |
| K900 | And then there's staging where pretty much every PR is red because ofborg can't catch up | 13:34:26 |
| K900 | (not that it should try to( | 13:34:34 |
| K900 | * (not that it should try to) | 13:34:38 |
 cole-h | Is there a documented number somewhere in nixpkgs that says "builds greater than this amount should target staging"? | 13:38:50 |
| K900 | https://nixos.org/manual/nixpkgs/unstable/#submitting-changes-staging-branch | 13:39:19 |
| cole-h | If so, I'd accept a PR adding a new, failing status check in the case that a PR's rebuilds exceeds that amount on any platform.
Otherwise, I'd want that to be codified somewhere before ofborg starts enforcing it. | 13:39:20 |
| K900 | "Mass rebuilds are commits that cause rebuilds for many packages, like more than 500 (or perhaps, if it’s “light” packages, 1000)." | 13:39:27 |
| K900 | I don't think it's really enforced all that much | 13:40:04 |
 ma27 | however there are exceptions, IIRC critical openssl patches went straight to master in the past for instance. | 13:40:22 |
| K900 | But around 2000 is usually where people start complaining | 13:40:25 |
| K900 | Or at least where I notice people complaining | 13:40:43 |
 tea | btw, kind of unrelated, but saving for later: why doesn't ofborg do nixpkgs-review-pr anymore? | 13:41:18 |
