| 10 Apr 2023 |
 K900 | No one sees those if there's like 100 comments | 13:27:45 |
| K900 | And the merge button is at the bottom | 13:27:51 |
| K900 | https://github.com/NixOS/nixpkgs/pull/218331 happened earlier today | 13:28:41 |
| K900 | We already have a check that fails when you try to target a channel branch | 13:29:39 |
| K900 | Would be nice to have something like that for staging | 13:29:57 |
 cole-h | While not ideal, I don't necessarily want to give PRs a big red X (a failed status check) unless something is broken. | 13:30:41 |
| K900 | Well github doesn't exactly have a warning state | 13:31:24 |
| K900 | And I think a big red X is preferable to merging 5000 rebuilds into master directly | 13:32:02 |
| cole-h | I'd also argue that there are valid cases where we'd want to merge a large rebuild to master (say, a massive vulnerability in glibc or openssl that allows RCE or things). | 13:32:15 |
| K900 | I'd expect anyone that actually needs to do this to know this is not fatal | 13:32:24 |
| K900 | Like, you can always ignore the check and merge | 13:32:50 |
| cole-h | Related to my last message is I don't want to cheapen the "big red X" from ofborg. If you get a big red X, that PR should not be merged in its current state, period. | 13:33:03 |
