| 11 Oct 2022 |
 cole-h | Hmm, I think I've seen it happen before but I don't know why it happens. I'll take a look tomorrow (I've set a reminder). | 00:54:29 |
 ncfavier | can we talk about the "pending status [that] will be cleared when ofborg starts eval" that's only cleared when ofborg finishes eval? | 10:11:17 |
| ncfavier | it is mildly infuriating | 10:11:37 |
| ncfavier | is it actually supposed to be cleared when ofborg starts eval, or should the text say "finishes"? | 10:12:26 |
| ncfavier | it looks like the former was intended: https://github.com/NixOS/ofborg/pull/527 | 10:30:49 |
| ncfavier | did that ever work? | 10:30:55 |
| cole-h | The "pending status" thing is entirely implemented in Nixpkgs, ofborg doesn't interact with it at all (the action interacts with the GitHub API to check if ofborg has any statuses, or something like that). The "clear pending action" is implemented here: https://github.com/NixOS/nixpkgs/blob/e32a01b9226da663106ceee40594443fef24dfda/.github/workflows/pending-clear.yml | 14:34:12 |
| cole-h | In reply to @qyliss:fairydust.space
Is something up with running NixOS tests on OfBorg? When hexa and I try to look up the logs of this OfBorg run https://github.com/NixOS/nixpkgs/pull/195437/checks?check_run_id=8812239013, we see 404 HTML where the logs should be. My intuition leads me to believe that can happen when the "build log" is empty for whatever reason (https://github.com/NixOS/ofborg/blob/231953bf2ee6304be2be1ea8d029fd76df1b3f5d/ofborg/src/tasks/build.rs#L371-L375). I looked at the logs and there is indeed nothing between those scissor lines, so that would make sense to me. I'm not particularly worried that it happened, but I'm curious as to why tests.installer didn't have any output there... | 14:37:44 |
| cole-h | 
Download image.png | 14:38:07 |
 hexa | probably cached? | 14:38:52 |
| cole-h | Yeah, that's what I'm thinking as well. | 14:39:07 |
| hexa | ideally cached should not 404 😛 | 14:39:20 |
| cole-h | More accurately, empty log should probably not 404 | 14:39:39 |
| cole-h | In reply to @ncfavier:matrix.org
is it actually supposed to be cleared when ofborg starts eval, or should the text say "finishes"? Essentially, I don't care either way, but I don't know if there's a way (using the API) to get the action to be marked successful once ofborg's started working on it. | 14:41:50 |
| cole-h | Maybe you could start with looking at the valid values for this and go from there: https://github.com/NixOS/nixpkgs/blob/e32a01b9226da663106ceee40594443fef24dfda/.github/workflows/pending-clear.yml#L5 | 14:47:10 |
| ncfavier | yeah i glanced over the API docs already but there's only completed | 15:03:04 |
| cole-h | If there's no other easy way to look at when ofborg first pushes a status, then I think changing the wording would be fine :) | 15:13:47 |
| 12 Oct 2022 |
 K900 | Where do I poke ofborg to make it recalculate the labels? | 11:35:38 |
| K900 | It's not doing that on https://github.com/NixOS/nixpkgs/pull/191357 | 11:35:43 |
| hexa | eval should to that imo | 11:42:56 |
| K900 | That's what I thought too | 12:06:18 |
| K900 | But it doesn't match my nixpkgs-review numbers | 12:06:30 |
| K900 | Unless it's also counting broken packages? | 12:06:39 |
| cole-h | You can see which packages it thinks has changed, and for which architecture, by clicking the "Details" link next to the ofborg-eval — ^.^! status. That'll tell you what ofborg thinks changed. | 16:28:41 |
| K900 | Oh | 16:29:42 |
| K900 | It does count broken packages | 16:29:52 |
| K900 | Is that intentional? | 16:29:57 |
| cole-h | Probably | 16:30:21 |
| K900 | It just misfires hard on KDE stuff because we have three different attrsets for Qt 5.12, 5.14 and 5.15 | 16:30:57 |
| K900 | And the KDE stuff is included in all three, but marked broken on <5.15 | 16:31:09 |
