| 3 Feb 2024 |
hexa | * thanks a ton | 02:41:10 |
| 9 Feb 2024 |
| @pinpox:matrix.org joined the room. | 12:04:08 |
@pinpox:matrix.org | crossposting here as requested:
ofborg is failing to run my test, even though it works fine locally. Can anyone tell me what I'm doing wrong? https://github.com/NixOS/nixpkgs/actions/runs/7843526136/job/21404048992?pr=287455 | 12:04:29 |
Artturin | In reply to @pinpox:matrix.org crossposting here as requested:
ofborg is failing to run my test, even though it works fine locally. Can anyone tell me what I'm doing wrong? https://github.com/NixOS/nixpkgs/actions/runs/7843526136/job/21404048992?pr=287455 That's not ofborg, it's https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/nix-parse.yml | 13:41:05 |
Artturin | Add the test to the passthru.tests of the package btw | 13:45:57 |
Artturin | pinpox: it passes now | 15:20:13 |
Artturin | check the darwin failure and drop the merge | 15:20:35 |
@pinpox:matrix.org | Artturin: I removed the merge but now it conflicts again | 20:59:30 |
@pinpox:matrix.org | I'm not sure how to resolve this | 20:59:43 |
Artturin | In reply to @pinpox:matrix.org Artturin: I removed the merge but now it conflicts again conflicts should be resolved via rebasing | 21:00:49 |
Artturin | https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-create-pull-requests 7. | 21:01:00 |
Artturin | In reply to @pinpox:matrix.org Artturin: I removed the merge but now it conflicts again * conflicts should be resolved by rebasing | 21:01:43 |
@pinpox:matrix.org | Artturin: got it fixed, thanks! | 21:06:35 |
@pinpox:matrix.org | * Artturin: got it fixed, thanks! Rebased and without conflicts now | 21:06:44 |
| 12 Feb 2024 |
@infinisil:matrix.org | Regarding https://github.com/NixOS/nixpkgs/pull/269403, I actually don't think it would improve ofborg speed at all | 00:53:17 |
@infinisil:matrix.org | * Regarding https://github.com/NixOS/nixpkgs/pull/269403, I actually don't think it would improve ofborg eval speed at all | 00:53:21 |
@infinisil:matrix.org | It gives a 5x speedup if you have 31 additional cores without anything to do | 00:53:55 |
@infinisil:matrix.org | Well I guess it depends on how booked-out ofborg generally is | 00:54:42 |