| 25 Dec 2023 |
 Lily Foster | In reply to @raphi:tapesoftware.net
i think because nix_2_3 is in aliases.nix so it doesn't get picked up in CI
nixVersions.nix_2_3 should work yeah but commit message should just be for builds iirc. it uses changed paths/attrs from the outpath calculation iirc (though maybe it had other problems with determining the changed path there idk or maybe it is something alias heckery) | 16:59:51 |
| Lily Foster | if i remember, i'll double check the code later | 17:00:15 |
| Lily Foster | * yeah but commit message should just be for builds iirc. it uses changed paths/attrs from the outpath calculation iirc for maintainer pings (though maybe it had other problems with determining the changed path there idk or maybe it is something alias heckery) | 17:00:31 |
 Artturin | In reply to @lily:lily.flowers
yeah but commit message should just be for builds iirc. it uses changed paths/attrs from the outpath calculation iirc (though maybe it had other problems with determining the changed path there idk or maybe it is something alias heckery) The maintainers for all reverse feps aren't pinged | 17:01:04 |
| Lily Foster | In reply to @artturin:matrix.org
The maintainers for all reverse feps aren't pinged i guess that's true, i'm probably just misremembering then | 17:03:55 |
| Lily Foster | (i really thought it based it on files touched for some reason though rather than commit messages....) | 17:04:24 |
| Lily Foster | * (i really thought it based it on source files touched for some reason though rather than commit messages....) | 17:04:32 |
| Lily Foster | (idk am on mobile and also with family rn so i can't check code) | 17:04:49 |
| Artturin | Ofborg doesn't use the source names for anything IIRC | 17:06:03 |
 trofi | I changed it to nixVersions.nix_2_3 and ofborg still did not add anyone :( | 19:11:02 |
| 26 Dec 2023 |
| Lily Foster | In reply to @artturin:matrix.org
Ofborg doesn't use the source names for anything IIRC i'm looking at the ofborg code and it definitely just does maintainer pings for any changed outpaths that also had a file modified in the PR that corresponds to the derivations' meta.maintainers, src, pname, or version attr positions: https://github.com/NixOS/ofborg/blob/de415d372959b7e6fc6b2f6c95f0c21e5010348d/ofborg/src/maintainers.nix#L56-L64 | 01:31:56 |
| Lily Foster | (i.e. so it requires that 1. the package has an attr, 2. the outpath for that package attr has changed, and 3. the meta.maintainers, src, pname, or version attribute for that package must be defined in one of the files that was changed) | 01:32:59 |
