!sBfrWMVsLoSyFTCkNv:nixos.org

OfBorg

175 Members
Number of builds and evals in queue: <TBD>62 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
4 May 2023
@raitobezarius:matrix.orgraitobezarius
{
  "cpuTime": 0.49957001209259033,
  "envs": {
    "bytes": 12506824,
    "elements": 609381,
    "number": 476986
  },
  "gc": {
    "heapSize": 402915328,
    "totalBytes": 87726480
  },
  "list": {
    "bytes": 1933232,
    "concats": 13049,
    "elements": 241654
  },
  "nrAvoided": 488806,
  "nrFunctionCalls": 412021,
  "nrLookups": 240540,
  "nrOpUpdateValuesCopied": 1193821,
  "nrOpUpdates": 12482,
  "nrPrimOpCalls": 244606,
  "nrThunks": 691079,
  "sets": {
    "bytes": 29699424,
    "elements": 1702651,
    "number": 153563
  },
  "sizes": {
    "Attr": 16,
    "Bindings": 16,
    "Env": 16,
    "Value": 24
  },
  "symbols": {
    "bytes": 531386,
    "number": 45882
  },
  "values": {
    "bytes": 27441768,
    "number": 1143407
  }
}
22:14:20
@raitobezarius:matrix.orgraitobezariusfor the nix show stats22:14:23
@cole-h:matrix.orgcole-hCool22:14:35
@raitobezarius:matrix.orgraitobezariusI mean I'm not aware of the performance constraints of ofborg, but I believe it's probably negligible?22:15:03
@cole-h:matrix.orgcole-hNot necessarily constraints, but when you start evaluating every PR on all of Nixpkgs, slowdowns can be noticeable22:16:00
@raitobezarius:matrix.orgraitobezariusOf course22:16:10
@cole-h:matrix.orgcole-hI'll take a closer look tomorrow, but it doesn't look immediately flawed, as long as performance doesn't massively regress :P22:18:35
@raitobezarius:matrix.orgraitobezarius:)22:18:52
@raitobezarius:matrix.orgraitobezariuslet me know22:18:55
@raitobezarius:matrix.orgraitobezariusI wished we could just run performance testing without setting the whole broker/worker stuff :D22:19:13
5 May 2023
@raitobezarius:matrix.orgraitobezariushttps://github.com/NixOS/ofborg/pull/562/files interesting PR to revive20:40:39
6 May 2023
@lily:lily.flowersLily Foster

Ofborg's ofborg-eval-package-list-no-aliases check is still missing a lot of alias usage (see https://github.com/NixOS/nixpkgs/pull/230188#pullrequestreview-1415772214)

I notice that adding --drv-path to the command here https://github.com/NixOS/ofborg/blob/0f34038feb9b0ae9959c865608700c91d57b2590/ofborg/src/tasks/eval/nixpkgs.rs#L455 lets it catch those, but obviously that makes it a more expensive eval (since it has to actually evaluate the entire drvs)

Is there a better way we can detect alias usage instead of having it pass PRs that fail with allowAliases = false?

14:13:15
@lily:lily.flowersLily Foster (I am also happy to open a PR to add --drv-path to that check, and just discuss it there. I just don't know much ofborg and idk how reasonable that solution is) 14:17:17
@vcunat:matrix.orgvcunatThe most expensive checks that I'm aware of running anywhere need around 36G RAM: https://github.com/NixOS/nixpkgs/issues/22794514:53:11
@vcunat:matrix.orgvcunat * The most expensive eval checks that I'm aware of running anywhere need around 36G RAM: https://github.com/NixOS/nixpkgs/issues/22794514:53:30

Show newer messages


Back to Room ListRoom Version: 6