| 26 Dec 2023 |
 raitobezarius | In reply to @lily:lily.flowers
a minor refactor that is something like this would make the magic work again if you really wanted it to trofi:
diff --git a/pkgs/tools/package-management/nix/common.nix b/pkgs/tools/package-management/nix/common.nix
index 0ea47dd7e17c..6d62d8a31bfd 100644
--- a/pkgs/tools/package-management/nix/common.nix
+++ b/pkgs/tools/package-management/nix/common.nix
@@ -5,7 +5,7 @@
, hash ? null
, src ? fetchFromGitHub { owner = "NixOS"; repo = "nix"; rev = version; inherit hash; }
, patches ? [ ]
-, maintainers ? with lib.maintainers; [ eelco lovesegfault artturin ]
+, meta ? {}
}:
assert (hash == null) -> (src != null);
let
@@ -243,10 +243,10 @@ self = stdenv.mkDerivation {
'';
homepage = "https://nixos.org/";
license = licenses.lgpl2Plus;
- inherit maintainers;
+ maintainers = with lib.maintainers; [ eelco lovesegfault artturin ];
platforms = platforms.unix;
outputsToInstall = [ "out" ] ++ optional enableDocumentation "man";
mainProgram = "nix";
- };
+ } // meta;
};
in self
diff --git a/pkgs/tools/package-management/nix/default.nix b/pkgs/tools/package-management/nix/default.nix
index 4652ddb76a5b..e1d566ecabaa 100644
--- a/pkgs/tools/package-management/nix/default.nix
+++ b/pkgs/tools/package-management/nix/default.nix
@@ -157,7 +157,7 @@ in lib.makeExtensible (self: ({
patches = [
patch-monitorfdhup
];
- maintainers = with lib.maintainers; [ flokli raitobezarius ];
+ meta.maintainers = with lib.maintainers; [ flokli raitobezarius ];
}).override { boehmgc = boehmgc-nix_2_3; };
nix_2_10 = common {
please send the patch; looks good to me :( | 05:16:21 |
 trofi | I must say I expected $attr.meta.maintainers to Just Work :( | 07:50:13 |
| trofi | Filed https://github.com/NixOS/ofborg/issues/668 if that makes sense. | 10:03:50 |
| trofi | As a workaround WDYT of adding a pos attribute to the lookup list? I could sprinkle a few pos = allocations for nix edit to do the right thing. | 10:36:42 |
| trofi | * As a workaround WDYT of adding a pos attribute to the lookup list? I could sprinkle a few pos = annotations for nix edit to do the right thing. | 10:36:55 |
| trofi | Proposed ofborg change as https://github.com/NixOS/ofborg/pull/669 | 10:42:59 |
| trofi | And proposed nix pos change as https://github.com/NixOS/nixpkgs/pull/276892 | 10:49:12 |
| 28 Dec 2023 |
|  piegames changed their display name from piegames to piegames [☎ 9712]. | 01:33:45 |
| 30 Dec 2023 |
| trofi | Looking at https://github.com/NixOS/nixpkgs/pull/277751 and at https://github.com/NixOS/nixpkgs/pull/277741 would it be reasonable for ofborg to try to eval all of passthru? Just an eval for uncatchable errors a few levels deep (like 2-3). | 16:59:31 |
| raitobezarius changed their display name from raitobezarius (DECT 2128) to raitobezarius. | 19:53:26 |
| 31 Dec 2023 |
| piegames changed their display name from piegames [☎ 9712] to piegames. | 12:40:53 |
| 2 Jan 2024 |
 @janik0:matrix.org | Hi, I don't know too much about ofborg but shouldn't it still ping maintainers even if it doesn't end up rebuilding the package? https://github.com/NixOS/nixpkgs/pull/277747 | 02:20:37 |
 Lily Foster | In reply to @janik0:matrix.org
Hi, I don't know too much about ofborg but shouldn't it still ping maintainers even if it doesn't end up rebuilding the package? https://github.com/NixOS/nixpkgs/pull/277747 not currently since it bases maintainer pings on attr rebuilds correlated to changed files. but i may end up changing it to also ping maintainers for all packages mentioned in commits | 02:21:44 |
| 4 Jan 2024 |
|  @a-n-n-a-l-e-e:matrix.org joined the room. | 13:18:25 |
| 5 Jan 2024 |
 @adam:robins.wtf | is there a way to rerun the auto detected build and tests? | 18:01:22 |
| Lily Foster | In reply to @adam:robins.wtf
is there a way to rerun the auto detected build and tests? @ofborg build [attr] [attr].passthru.tests and it'll overwrite the original checks with a new build since the check name would match | 18:02:07 |
| @adam:robins.wtf | thanks. i would be nice to have a keyword that could just do that for us. e.g. @ofborg rebuild or something | 18:02:47 |
| @adam:robins.wtf | * thanks. it would be nice to have a keyword that could just do that for us. e.g. @ofborg rebuild or something | 18:03:25 |
| Lily Foster | In reply to @adam:robins.wtf
thanks. i would be nice to have a keyword that could just do that for us. e.g. @ofborg rebuild or something i'll add it the list | 18:03:48 |
| 6 Jan 2024 |
|  Julien joined the room. | 13:57:58 |
| Julien | Ofborg tells me it has no space left on device, is there anything that has to be done by a human or the machine is going to reset at some point automatically ?
https://logs.ofborg.org/?key=nixos/nixpkgs.273062&attempt_id=a8f2a8f3-e050-4610-a6bc-d7443af0f673 | 13:58:41 |
| 7 Jan 2024 |
|  ghpzin joined the room. | 15:33:55 |
| 10 Jan 2024 |
| ghpzin changed their display name from 9hp71n to ghpzin. | 06:33:13 |
|  philipp changed their display name from philipp to test. | 13:48:33 |
| philipp changed their display name from test to philipp. | 13:49:59 |
| 11 Jan 2024 |
 pbsds | ofborg doesn't seem to request reviews from package maintainers, is this a known issue? | 01:06:55 |
| Lily Foster | In reply to @pederbs:pvv.ntnu.no
ofborg doesn't seem to request reviews from package maintainers, is this a known issue? link to pr with issue? | 01:20:56 |
| pbsds | I seem to be mistaken | 01:25:35 |
 ElvishJerricco | ofborg failed to build a test for a PR for a very strange reason. Is this something to worry about? https://logs.ofborg.org/?key=nixos/nixpkgs.280296&attempt_id=9716e851-de93-4b2a-a937-9fbf9acc4eb8 | 16:13:47 |
| Lily Foster | In reply to @elvishjerricco:matrix.org
ofborg failed to build a test for a PR for a very strange reason. Is this something to worry about? https://logs.ofborg.org/?key=nixos/nixpkgs.280296&attempt_id=9716e851-de93-4b2a-a937-9fbf9acc4eb8 the no space left bit? | 16:14:28 |
