!sBfrWMVsLoSyFTCkNv:nixos.org

OfBorg

173 Members
Number of builds and evals in queue: <TBD>63 Servers

Load older messages


SenderMessageTime
9 Jan 2022
@winterqt:nixos.devWinter (she/her)Is sandbox enabled on the Darwin builders?22:34:46
@winterqt:nixos.devWinter (she/her) * Is the sandbox enabled on the Darwin builders?22:34:49
@winterqt:nixos.devWinter (she/her)

Hey grahamc (he/him) -- I'm looking at ImpactedMaintainers::calculate, and I notice this expression:

        let mut cmd = nix.safely_evaluate_expr_cmd(
            checkout,
            include_str!("./maintainers.nix"),
            argstrs,
            &[path_file.path(), attr_file.path()],
        );

Why do you add the 2 tempfiles (path_file, attr_file) to safe_paths, which seemingly just adds them to NIX_PATH? Do they need to be there for whatever reason? I ask since maintainers.nix just imports them by absolute path, not <...>.

22:56:00
@winterqt:nixos.devWinter (she/her)Thanks!22:56:10
@winterqt:nixos.devWinter (she/her)Oh, never mind.22:57:04
@winterqt:nixos.devWinter (she/her) * Oh, nevermind.22:57:07
@winterqt:nixos.devWinter (she/her) I should've dug a bit more deeper -- restrict-eval only allows paths in NIX_PATH to be accessed. 22:57:20
@winterqt:nixos.devWinter (she/her)That makes sense, sorry for the ping.22:57:25
@hexa:lossy.networkhexa
In reply to @winterqt:nixos.dev
Is the sandbox enabled on the Darwin builders?
I don't believe there is a working sandbox on darwin
23:50:14
10 Jan 2022
@winterqt:nixos.devWinter (she/her)
In reply to @hexa:lossy.network
I don't believe there is a working sandbox on darwin
There definitely is (I have it enabled)
00:10:18
@winterqt:nixos.devWinter (she/her)But it’s not without its breakages00:10:25
@winterqt:nixos.devWinter (she/her) Is there any way that I can run OfBorg locally just to debug a specific task? (calculating changed attributes)
Or should I just do the things it does to do that manually, idk.
The latter is probably simpler
00:12:29
@winterqt:nixos.devWinter (she/her)(I know I asked a similar question earlier so I don’t know why I’m asking again, sorry.$00:13:08
@winterqt:nixos.devWinter (she/her)* (I know I asked a similar question earlier so I don’t know why I’m asking again, sorry.)00:13:12
@piegames:matrix.orgpiegames
In reply to @winterqt:nixos.dev
Is there any way that I can run OfBorg locally just to debug a specific task? (calculating changed attributes)
Or should I just do the things it does to do that manually, idk.
The latter is probably simpler
Ah, I found it https://github.com/NixOS/ofborg/pull/562 (FWIW)
00:16:46
@winterqt:nixos.devWinter (she/her)I’ll take a look, thanks.00:26:56
@winterqt:nixos.devWinter (she/her) So an issue that I ran into was that https://github.com/NixOS/nixpkgs/pull/153038#discussion_r780785733 (go to the last resolved discussion and expand it) didn’t cause OfBorg to detect myself as a maintainer. But I’m… not really sure why. I can successfully go into a REPL and see that thelounge.meta.maintainers exists.
Does anyone have any pointers on why this would be happening, or where to look in the codebase, or something?
00:29:16
@winterqt:nixos.devWinter (she/her) * So an issue that I ran into was that https://github.com/NixOS/nixpkgs/pull/153038#discussion_r780785733 (go to the last resolved discussion and expand it) didn’t cause OfBorg to detect myself as a maintainer (and add the by package maintainer label). But I’m… not really sure why. I can successfully go into a REPL and see that thelounge.meta.maintainers exists.
Does anyone have any pointers on why this would be happening, or where to look in the codebase, or something?
00:30:09
@winterqt:nixos.devWinter (she/her)Nothing immediately stands out to me :/00:32:51
@sternenseemann:systemli.orgsterni Winter (she/her): ofborg relies on the attribute names in the commit message mostly, so the PR wouldn't trigger that code because there's no thelounge: … commit, I would assume? 11:10:29
12 Jan 2022
@grahamc:nixos.org@grahamc:nixos.org I think “thelounge:” is only for triggering builds, not @ing maintainers. This is to encourage good commit message format, but still @ing relevant people even if the author didn’t do it quite right 14:33:27
@winterqt:nixos.devWinter (she/her)
In reply to @grahamc:nixos.org
I think “thelounge:” is only for triggering builds, not @ing maintainers. This is to encourage good commit message format, but still @ing relevant people even if the author didn’t do it quite right
I’m confused. You said it’s not for @ing but it would @ anyways?
14:38:37
@winterqt:nixos.devWinter (she/her)(I’ll reword my commits to use the actual attribute name, though; thanks for the clarification.)14:39:46
@winterqt:nixos.devWinter (she/her) *
In reply to @grahamc:nixos.org
I think “thelounge:” is only for triggering builds, not @ing maintainers. This is to encourage good commit message format, but still @ing relevant people even if the author didn’t do it quite right
I’m confused. You said it’s not for @ing but that it would @ anyways?
14:44:14
@grahamc:nixos.org@grahamc:nixos.org There is a rule that determines what things to build, and that rule is based on attribute as named in the commit message with the prefix. It has nothing to do with @ing people, iirc. 14:45:44
@winterqt:nixos.devWinter (she/her)Ah, understood.14:46:50
@sternenseemann:systemli.orgsterniyeah seems like that should use the changed attribute paths14:58:34
@ncfavier:matrix.orgncfavier joined the room.16:08:55
13 Jan 2022
@mjolnir:nixos.orgNixOS Moderation Bot unbanned @blaggacao:matrix.orgDavid Arnold (blaggacao).18:43:45
14 Jan 2022
@cw:kernelpanic.cafeChinchilla Washington changed their display name from Rev. CornWallace III (novus ordo seclorum) to coilWinder.04:39:47

Show newer messages


Back to Room ListRoom Version: 6