!sBfrWMVsLoSyFTCkNv:nixos.org

OfBorg

170 Members
Number of builds and evals in queue: <TBD>64 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
24 May 2024
@7c6f434c:nitro.chat7c6f434cDistinguishing the cases is some non-trivial work, not just switching a single constant06:15:26
@trofi:matrix.orgtrofi

Sure, but it's so sad to see thing like:

$ nix build --no-link -f. nixVersions.git.tests
...
error: attribute 'nix_2_23' missing
Did you mean one of nix_2_13, nix_2_20, nix_2_21, nix_2_22 or nix_2_3?
06:15:26
@trofi:matrix.orgtrofi At least "no tests specified" feels like a simple case of changing the evaluator to discover tests with $foo.tests or [] instead of $foo.tests. 06:16:34
@7c6f434c:nitro.chat7c6f434cI think right evaluation failures are handled the same for tests and for packages06:17:12
@lily:lily.flowersLily Fosterthere was a check-meta check to make sure tests was an attrset of derivations11:13:50
@lily:lily.flowersLily Fosterbut11:13:52
@lily:lily.flowersLily Fosterwhen tests were moved from meta.tests to passthru.tests before that PR was merged11:14:14
@lily:lily.flowersLily Fosterthe check-meta check was not updated11:14:20
@lily:lily.flowersLily Fosterso it's not useful right now11:14:27
@lily:lily.flowersLily Fosterbut checking it there-ish would be ideal11:14:49
@lily:lily.flowersLily Foster(and then abort-ish eval failures (e.g. syntax errors) vs throw-ish eval failures would also be differentiated, as intended by most eval checks)11:15:52
@lily:lily.flowersLily Foster* (and then abort-ish eval failures (e.g. syntax errors) vs throw-ish eval failures (e.g. not available on platform) would also be differentiated, as intended by most eval checks)11:16:18
27 May 2024
@vcunat:matrix.orgvcunatAny idea if the eval label mechanism is broken? It got completely wrong in this case: https://github.com/NixOS/nixpkgs/pull/314255#issuecomment-213278143907:06:12
@vcunat:matrix.orgvcunat(also in the original PR from which this backport was created)07:07:28
@vcunat:matrix.orgvcunatOr do the linux rebuild labels not take aarch64-linux into account?07:07:58

Show newer messages


Back to Room ListRoom Version: 6